Skip to content

websocket: resolve relative urls in constructor#42425

Merged
simonwuelker merged 1 commit intoservo:mainfrom
webbeef:websocket-constructor
Feb 7, 2026
Merged

websocket: resolve relative urls in constructor#42425
simonwuelker merged 1 commit intoservo:mainfrom
webbeef:websocket-constructor

Conversation

@webbeef
Copy link
Copy Markdown
Contributor

@webbeef webbeef commented Feb 7, 2026

Implement steps 1. and 2. of the websocket constructor to resolve the url against the current settings API base URL.

Testing: Some WPT tests are now passing

Signed-off-by: webbeef <me@webbeef.org>
@webbeef webbeef requested a review from gterzian as a code owner February 7, 2026 15:46
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 7, 2026
Copy link
Copy Markdown
Member

@simonwuelker simonwuelker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 7, 2026
@simonwuelker simonwuelker added this pull request to the merge queue Feb 7, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 7, 2026
Copy link
Copy Markdown
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good find!

Merged via the queue into servo:main with commit 5b54abe Feb 7, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants