canvas: Change canvas to use JSContext instead of CanGc#42662
canvas: Change canvas to use JSContext instead of CanGc#42662sagudev merged 2 commits intoservo:mainfrom
Conversation
|
I mostly did this to understand the JSContext changes coming up.
|
Yes, I need to fix codegen for them. I will do this tomorrow.
I think deserialize actually needs to get cx passed as arg.
I will check it tomorrow. |
|
I fixed codegen for constructor in f623081 and this PR looks alright. I think we should defer ImageData changes to after we pass cx in serialize. |
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
d312b02 to
39afca0
Compare
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
|
Ok done. |
Ah, I need to write methods that will take &mut JSContext. |
This changes the methods in dom/canvas to use the new JSContext/&mut JSContext instead of CanGc.
Part of #40600
Signed-off-by: Narfinger Narfinger@users.noreply.github.com
Testing: This is a refactor, hence, compilation is the test.