Skip to content

webdriver: Do nothing for dispatch_pause_action#43014

Merged
yezhizhen merged 1 commit intoservo:mainfrom
yezhizhen:fix-pause
Mar 5, 2026
Merged

webdriver: Do nothing for dispatch_pause_action#43014
yezhizhen merged 1 commit intoservo:mainfrom
yezhizhen:fix-pause

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

@yezhizhen yezhizhen commented Mar 4, 2026

We should not try to create a input id here: it is already done in
https://w3c.github.io/webdriver/#dfn-process-an-input-source-action-sequence

The sole effect of the action is that its duration parameter may decide "tick duration".

@yezhizhen yezhizhen requested a review from xiaochengh March 4, 2026 10:08
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 4, 2026
@yezhizhen yezhizhen force-pushed the fix-pause branch 2 times, most recently from be5afb9 to d9ddf81 Compare March 4, 2026 10:10
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 4, 2026
@yezhizhen yezhizhen added this pull request to the merge queue Mar 5, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 5, 2026
@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Mar 5, 2026

I left this empty instead of removing for better "code search" and comments. The spec for the action can change in future too.

Merged via the queue into servo:main with commit 6a98cdc Mar 5, 2026
30 checks passed
@yezhizhen yezhizhen deleted the fix-pause branch March 5, 2026 02:42
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 5, 2026
@delan
Copy link
Copy Markdown
Member

delan commented Apr 20, 2026

hi! i’m working on the monthly update. is this change observable by webdriver clients?

@yezhizhen
Copy link
Copy Markdown
Member Author

hi! i’m working on the monthly update. is this change observable by webdriver clients?

This just avoids redundant work and the change itself is not observable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants