script: Fix lookup of properties of DOMStringMap#43046
Merged
TimvdLippe merged 2 commits intoservo:mainfrom Mar 6, 2026
Merged
script: Fix lookup of properties of DOMStringMap#43046TimvdLippe merged 2 commits intoservo:mainfrom
TimvdLippe merged 2 commits intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
|
🔨 Triggering try run (#22736616832) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22736616832): Flaky unexpected result (36)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (1)
|
|
|
jdm
approved these changes
Mar 6, 2026
servo-highfive
removed
the
S-awaiting-review
jdm
reviewed
Mar 6, 2026
The conversion of strings was wrong for `--foo` where it should become `-Foo`. Instead, it was consuming both the `--` and then would encounter a `f`. This moves the relevant algorithms to DOMStringMap and adds corresponding spec comments to explain what's going on. This does make us closer to passing `html/dom/elements/global-attributes/dataset-delete.html` but unfortunately it still fails because of servo#12978 Prior to this fix, the value of `d.dataset['-foo']` wasn't undefined. However, we now fail the assertion where the attribute should remain, despite the call to delete. That's because per `LegacyOverrideBuiltIns` we should be checking the existence of which properties it can delete, before it actually deletes the attribute. Right now, we do it regardless if it is a valid property and thus we incorrectly delete the attribute. Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
TimvdLippe
force-pushed
the
fix-domstring-map-implementation
branch
from
9177aac to
61605f1
Compare
servo-highfive
added
the
S-awaiting-review
Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion of strings was wrong for
--foowhere it should become-Foo. Instead, it was consuming both the--and then would encounter af.This moves the relevant algorithms to DOMStringMap and adds corresponding spec comments to explain what's going on.
This does make us closer to passing
html/dom/elements/global-attributes/dataset-delete.htmlbut unfortunately it still fails because of #12978Prior to this fix, the value of
d.dataset['-foo']wasn't undefined. However, we now fail the assertion where the attribute should remain, despite the call to delete.That's because per
LegacyOverrideBuiltInswe should be checking the existence of which properties it can delete, before it actually deletes the attribute. Right now, we do it regardless if it is a valid property and thus we incorrectly delete the attribute.Testing: No change in tests, since the test in question has more assertions that require more fixes