script: Use UnrootedSimpleNodeIterator in delete_cell_or_row#43476
Merged
jdm merged 1 commit intoservo:mainfrom Mar 20, 2026
Merged
script: Use UnrootedSimpleNodeIterator in delete_cell_or_row#43476jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
Narfinger
changed the title
Narfinger
force-pushed
the
even-more-efficient-iterators
branch
from
a66e6bf to
186b095
Compare
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
servo-highfive
added
the
S-awaiting-review
|
🔨 Triggering try run (#23339166404) for Linux (WPT) |
|
Test results for linux-wpt from try job (#23339166404): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#23339166404) succeeded. |
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
niyabits
pushed a commit
to niyabits/servo
that referenced
this pull request
Mar 21, 2026
…3476) This uses UnrootedSimpleNodeIterator in a couple of places, namely - delete_cell_or_row - children_changed - move_fn More importantly this implements upcast and downcast for `UnrootedDom`. These methods work the same as the DomRoot methods except that they carry the no_gc and, hence, keep the lifetime. Testing: WPT tests will see if this breaks something. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com> Signed-off-by: Niya Gupta <niyabits@gmail.com>
Gae24
pushed a commit
to Gae24/servo
that referenced
this pull request
Mar 26, 2026
…3476) This uses UnrootedSimpleNodeIterator in a couple of places, namely - delete_cell_or_row - children_changed - move_fn More importantly this implements upcast and downcast for `UnrootedDom`. These methods work the same as the DomRoot methods except that they carry the no_gc and, hence, keep the lifetime. Testing: WPT tests will see if this breaks something. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses UnrootedSimpleNodeIterator in a couple of places, namely
More importantly this implements upcast and downcast for
UnrootedDom.These methods work the same as the DomRoot methods except that they carry the no_gc and, hence,
keep the lifetime.
Testing: WPT tests will see if this breaks something.