Gamepad: Implement gamepad buttons to be array, removing GamepadList

[rovertrack]

Replaced GamepadButtonList interface with a frozen array of gamepad buttons to match the gamepad webidl specification.

Testing: No idlharness tests possible since the values can't be accessed without a real gamepad.
Fixes: #44333

[mrobinson]

@rovertrack The Testing field should not contain a screenshot, but describe the automated tests that test this change.

[rovertrack]

Thanks @Gae24 , all suggested improvements have been made
now the init_button returns buttons and the conversion to inline with rooted_vec! happens in the constructor itself!

[Gae24]

Thanks!

[rovertrack]

is there any changes to be done on this @jdm?

[Gae24]

is there any changes to be done on this @jdm?

Actually could you check if tests/wpt/tests/gamepad/idlharness-manual.html cover these changes?

[rovertrack]

I think instead of the suggested "any" this must be FrozenArray<GamepadButton>so it checks the type of the buttons in

servo/tests/wpt/tests/resources/idlharness.js

Lines 528 to 530 in 9189fe0

	if (type.generic == "sequence" || type.generic == "FrozenArray") {
	return this.is_json_type(idlType[0]);
	}

[jdm]

Our webidl codegen doesn't support FrozenArray types.

[rovertrack]

Thanks for the clarity 🙂

[jdm]

Replaced the Gamepadbuttonlist type with any to implement Frozenarray - components/script_bindings/webidls/Gamepad.webidl
made the buttons usage in components/script/dom/gamepad/gamepad.rs be implemented with CachedFrozenArray so that the buttons are cached frozen_buttons. replacing dependency of Gamepadbuttonlist
Implemented a init_buttons same as the one with Gamepadlist.rs to remove, Removed Gampadbuttonlist completely

Tested with a physical controller
servo:

I'm editing the original description to include a more clear commit message (since it will be used for the squashed commits). Here's the original message for posterity.

[rovertrack]

Replaced the Gamepadbuttonlist type with any to implement Frozenarray - components/script_bindings/webidls/Gamepad.webidl
made the buttons usage in components/script/dom/gamepad/gamepad.rs be implemented with CachedFrozenArray so that the buttons are cached frozen_buttons. replacing dependency of Gamepadbuttonlist
Implemented a init_buttons same as the one with Gamepadlist.rs to remove, Removed Gampadbuttonlist completely

Tested with a physical controller
servo:

I'm editing the original description to include a more clear commit message (since it will be used for the squashed commits). Here's the original message for posterity.

Thanks @jdm.

[rovertrack]

@jdm Merge Failed due to GamePadButtonList being present in tests while this PR completely removes it, I have updated the PR to remove the test expectations!

[jdm]

Excellent, thanks! This just needs to be rebased against main and run ./mach update-manifest again.

[rovertrack]

Excellent, thanks! This just needs to be rebased against main and run ./mach update-manifest again.

Rebased and updated the manifest!

[rovertrack]

Thanks @Gae24.