Implement async version for cookie APIs#44708
Open
longvatrong111 wants to merge 2 commits into
Open
Conversation
Add an optional callback to current synchronous APIs to allow asynchronous operation. Signed-off-by: batu_hoang <longvatrong111@gmail.com>
servo-highfive
added
the
S-awaiting-review
Taym95
reviewed
May 10, 2026
| } | ||
|
|
||
| /// Asynchronously returns the cookies for the domain associated with the given [`Url`]. | ||
| pub fn cookies_for_url_async( |
Member
There was a problem hiding this comment.
this makes every sync caller do .unwrap() and every async caller ignore a returned Option, api is little bit awkward now, I would prefer keeping separate methods.
Contributor
Author
There was a problem hiding this comment.
I was also noticed and had some same thoughts. Maybe for only get cookie, it's more reasonable to keep 2 separate methods.
Let's wait for the opinions of others.
Contributor
Author
There was a problem hiding this comment.
@Taym95 Seem like there is no more review. I've updated thank you.
| } | ||
|
|
||
| pub fn clear_cookies_async(&self, id: CookieOperationId) { | ||
| let _ = self |
Member
There was a problem hiding this comment.
what happen when one send fails, will the callback never fires?
Contributor
Author
There was a problem hiding this comment.
yes, I think the callback is like onSuccess.
Signed-off-by: batu_hoang <longvatrong111@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #44166 (comment), this PR adds an optional callback to current synchronous APIs to allow asynchronous operation.
Test: existing unit tests of
SiteDataManager.