Support transforms for display list optimization. Prevents clipping in #6643.#6983
Merged
bors-servo merged 1 commit intoservo:masterfrom Aug 5, 2015
Merged
Support transforms for display list optimization. Prevents clipping in #6643.#6983bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
Member
glennw
commented
Aug 5, 2015
glennw
commented
Member
Author
|
r? @pcwalton |
Contributor
|
Why is DL optimization needed to clip properly? |
Member
Author
|
When I say clipping, I'm referring to items being culled incorrectly from some tiles without this change, which gives the appearance that an item is being clipped at tile boundaries. If that makes it clearer? |
Contributor
|
Ah, I see. So we were not taking transforms into account but were attempting to optimize anyway. |
Member
Author
|
Yep, that's right. |
Member
Author
There was a problem hiding this comment.
It's a slight optimization - the if checks below previously excluded them anyway, this just avoids adding them to the smallvec at all.
Contributor
|
@bors-servo: r+ |
Contributor
|
📌 Commit 11b1c19 has been approved by |
jdm
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Aug 5, 2015
Support transforms for display list optimization. Prevents clipping in #6643. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6983) <!-- Reviewable:end -->
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.