Support font-variant-alternates and @font-feature-values for servo - #377
Merged
Conversation
jdm
approved these changes
Jun 3, 2026
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
force-pushed
the
font-variant-alternates
branch
from
July 10, 2026 12:43
b1220cf to
8de1e44
Compare
Loirooriol
reviewed
Jul 10, 2026
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Member
Author
|
The servo PR is approved, so this can be merged now. |
nicoburns
pushed a commit
to nicoburns/servo
that referenced
this pull request
Jul 17, 2026
This change is more complicated than the other `font-variant-*` related PRs because `font-variant-alternates` requires the `@font-feature-values` rule to work. I've added a `FontFeatureValuesMap` to `LayoutContext` to efficiently map from identifiers in `font-variant-alternates` to the font-specific indices. This map is lazily initialized when needed and invalidated whenever the stylesheets change. To correctly perform lookups into the map we also need to compute the family name for a given font. This is platform specific code and I don't have access to macos/windows, so we only support freetype for now. Presumably adding support for more platforms would not be difficult. Note that for web fonts the property is supported on all systems, because those specify `font-family` inside the `@font-face` rule. Testing: New tests start to pass Depends on servo/stylo#377 --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Sep 2, 2026
…lues` for servo. r=firefox-style-system-reviewers,emilio This imports servo/stylo#377, with some tweak due to changes from https://phabricator.services.mozilla.com/D315884 Differential Revision: https://phabricator.services.mozilla.com/D322774
github-actions Bot
pushed a commit
to DioxusLabs/stylo
that referenced
this pull request
Sep 3, 2026
…lues` for servo. r=firefox-style-system-reviewers,emilio This imports servo#377, with some tweak due to changes from https://phabricator.services.mozilla.com/D315884 Differential Revision: https://phabricator.services.mozilla.com/D322774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Servo PR: servo/servo#45308