Skip to content

chore: [PRODUCT-328] remove extraneous/defunct release script from package.json#132

Merged
sigmachirality merged 2 commits into
mainfrom
dt/remove-release-script
Apr 28, 2025
Merged

chore: [PRODUCT-328] remove extraneous/defunct release script from package.json#132
sigmachirality merged 2 commits into
mainfrom
dt/remove-release-script

Conversation

@sigmachirality
Copy link
Copy Markdown
Member

This prevents people from accidentally running it instead of the release GA workflow.

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 26, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  package.json  0% smaller
  src/scripts/release.ts  0% smaller

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes the local release script and its package.json entry, consolidating release management exclusively through GitHub Actions workflows.

  • Removes src/scripts/release.ts which handled version bumping, compilation, and GitHub releases
  • Removes release script from package.json to prevent accidental local execution
  • All release functionality is now handled through .github/workflows/release.yml workflow
  • Workflow maintains same version bump options (major/minor/patch/prerelease) as the original script
  • Consider updating README.md to remove any references to local release script usage

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment thread package.json
@@ -1,7 +1,6 @@
{
"scripts": {
"devv": "IS_DEVELOPMENT_CLI_ENV=true deno run --allow-all src/index.ts",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider renaming 'devv' to 'dev' for consistency with common npm script naming conventions

@sigmachirality sigmachirality merged commit fae6656 into main Apr 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants