revert: restore release script for workflow#134
Merged
Conversation
|
Review changes with |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR restores the release automation script that handles version management, multi-architecture binary compilation, and GitHub release creation for the CLI.
- Added error handling for version bumping in
src/scripts/release.tswith support for major, minor, patch, and prerelease versions - Implemented multi-architecture binary compilation for x86_64/aarch64 on Linux/Darwin in
src/scripts/release.ts - Added zip file validation checks before GitHub release creation in
src/scripts/release.ts - Integrated with GitHub CLI for automated release creation and asset uploading
- Added graceful interrupt handling with confirmation prompt for release process
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+16
to
+21
| const [major, minor, patch] = version.split(".").map((v) => | ||
| Number.parseInt( | ||
| // Remove everything after the - if there is one | ||
| v.includes("-") ? v.split("-")[0] : v, | ||
| ) | ||
| ); |
Contributor
There was a problem hiding this comment.
style: Version parsing could throw on invalid version strings. Add try/catch and validation
Comment on lines
+92
to
+101
| async function asyncSpawn(cmds: string[]) { | ||
| console.log("cmds", cmds); | ||
| const result = await new Deno.Command(cmds[0], { | ||
| args: cmds.slice(1), | ||
| }).output(); | ||
|
|
||
| return { | ||
| exitCode: result.success ? 0 : 1, | ||
| }; | ||
| } |
Contributor
There was a problem hiding this comment.
style: asyncSpawn doesn't capture stderr output which could hide important error details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132 which broke the github release workflow
release.tsscript.