Fixed libraryTarget key spelling, since it's critical! #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@kodemunki Thanks! @alexfedoseev, @samnang, how did this work being misspelled? I'm going to look into this now. |
Member
Member
|
@kodemunki Please let me know if you want to update your PR to reflect that, and I'l merge, or else I'll make a new branch within the day to do this. The misspelling did not matter since we're using the globals syntax for server rendering. |
Project does not need to specify libraryTarget if using global.MyComponent rather than the expose syntax for server rendering.
Author
|
@justin808 thanks for looking into this, I was wondering how it was working too! |
Member
|
#109 is taking care of this. Thanks @kodemunki. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://webpack.github.io/docs/configuration.html#output-librarytarget