Updated docs for libraryTarget info #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not need to specify libraryTarget if using global.MyComponent rather than the expose syntax for server rendering.
Member
Author
|
@samnang, @alexfedoseev, @dylangrafmyre, @mapreal19, @josiasds FYI. I will merge with one LGTM. |
Contributor
|
LGTM. |
justin808
added a commit
that referenced
this pull request
Oct 5, 2015
Updated docs for libraryTarget info
Member
|
LGTM. |
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 25, 2025
Important: * All renderer config settings begin with `renderer_` * Password will use the password in the URL if not provided separately * URL will default to localhost:3800 if not provided (or is missing say from an ENV value). Also: * Use the correct error class * Make sure empty password gets ignored * Various cleanup of configuration and docs * Provide setup for running tests without the VmRenderer * Missing tests for spec/react_on_rails_pro for ci * remove poltergeist * fix circleci config * remove rspec/retry
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 26, 2025
Important: * All renderer config settings begin with `renderer_` * Password will use the password in the URL if not provided separately * URL will default to localhost:3800 if not provided (or is missing say from an ENV value). Also: * Use the correct error class * Make sure empty password gets ignored * Various cleanup of configuration and docs * Provide setup for running tests without the VmRenderer * Missing tests for spec/react_on_rails_pro for ci * remove poltergeist * fix circleci config * remove rspec/retry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not need to specify libraryTarget if using global.MyComponent
rather than the expose syntax for server rendering.