Skip to content

Add key to pin modal#57

Merged
bootsboogie merged 1 commit intodevelopfrom
pin-modal
Sep 7, 2021
Merged

Add key to pin modal#57
bootsboogie merged 1 commit intodevelopfrom
pin-modal

Conversation

@unclerom
Copy link
Contributor

@unclerom unclerom commented Sep 3, 2021

Notice

Before submitting a pull request, please make sure you have answered the following:

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Do all new and existing tests pass? Does the linter pass?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #28

Description

Add key to pin modal btns

Testing

Please outline all testing steps

Open KK pin modal no error in console

Screenshots (if applicable)

@unclerom unclerom requested a review from a team as a code owner September 3, 2021 02:57
Copy link
Contributor

@bootsboogie bootsboogie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for contributing!

@bootsboogie bootsboogie merged commit 81cd45e into develop Sep 7, 2021
@bootsboogie bootsboogie deleted the pin-modal branch September 7, 2021 18:03
bootsboogie added a commit that referenced this pull request Sep 8, 2021
* Add tests for dispatch SET_WALLET_MODAL and SET_IS_CONNECTED

* Remove initialized since it is not used

* Add more tests for WalletProvider

* Add coverage to test runner

* Make tests alittle better

* dry up a bit

* clean up of RawText to text.components (#8) (#56)

* clean up of RawText to text.components

* Update src/assets/translations/messages-en.json

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>

* abbreviated variables to full-length

* update nativeTest -> nativeTestPhrase

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>

* add key to pin modal (#57)

* Fix broken links for license and welcome prs (#51)

* Wallet updates (#44)

* wallet updates

* fix type on button

* lint

* set wallet info with wallet

* asset provider (#67)

* Add tests for dispatch SET_WALLET_MODAL and SET_IS_CONNECTED

* Remove initialized since it is not used

* Add more tests for WalletProvider

* Add coverage to test runner

* Make tests alittle better

* dry up a bit

* Fix broken tests from merge

* Write tests for connect function

Co-authored-by: 420coupe <35115310+420coupe@users.noreply.github.com>
Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>
Co-authored-by: duv <29046942+unclerom@users.noreply.github.com>
Co-authored-by: Itgel Ganbold <13912728+iganbold@users.noreply.github.com>
Co-authored-by: Sean Luther <elmutt@gmail.com>
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 24bd07f
Status: ✅  Deploy successful!
Preview URL: https://096b2451.web-29e.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PinModal needs unique key added to Buttons map

3 participants