Skip to content

Test WalletProvider#60

Merged
bootsboogie merged 20 commits intodevelopfrom
WEB-18
Sep 8, 2021
Merged

Test WalletProvider#60
bootsboogie merged 20 commits intodevelopfrom
WEB-18

Conversation

@bootsboogie
Copy link
Contributor

@bootsboogie bootsboogie commented Sep 3, 2021 •
edited
Loading

Notice

Before submitting a pull request, please make sure you have answered the following:

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Do all new and existing tests pass? Does the linter pass?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #18

Description

Added test coverage to the WalletProvider. I removed the initialized state cause it was not being used.

Testing

Please outline all testing steps

  1. Pull branch locally and run yarn to install new deps
  2. etc...

Screenshots (if applicable)

@bootsboogie bootsboogie requested a review from a team as a code owner September 3, 2021 15:08
unclerom
unclerom approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@unclerom unclerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope 🏆

@bootsboogie
Copy link
Contributor Author

bootsboogie commented Sep 3, 2021

Just waiting for #44 to be merged before I update and merge this one.

420coupe and others added 14 commits September 7, 2021 12:03
@420coupe @0xdef1cafe
clean up of RawText to text.components (#8) (#56)
22e672a 
* clean up of RawText to text.components

* Update src/assets/translations/messages-en.json

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>

* abbreviated variables to full-length

* update nativeTest -> nativeTestPhrase

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>
@unclerom
add key to pin modal (#57)
81cd45e
@iganbold
Fix broken links for license and welcome prs (#51)
83d88c4
@unclerom
Wallet updates (#44)
52ed92d 
* wallet updates

* fix type on button

* lint

* set wallet info with wallet
@elmutt
asset provider (#67)
512f124
@bootsboogie
Add tests for dispatch SET_WALLET_MODAL and SET_IS_CONNECTED
f6dfe7b
@bootsboogie
Remove initialized since it is not used
77e0861
@bootsboogie
Add more tests for WalletProvider
0e1a341
@bootsboogie
Add coverage to test runner
eda8401
@bootsboogie
Make tests alittle better
5faea21
@bootsboogie
dry up a bit
4443143
@bootsboogie
Fix broken tests from merge
3c37056
@bootsboogie
Write tests for connect function
f927a40
@bootsboogie
Merge branch 'WEB-18' of github-ss:shapeshift/web into WEB-18
51355c4
@bootsboogie bootsboogie merged commit 98a8a76 into develop Sep 8, 2021
@bootsboogie bootsboogie deleted the WEB-18 branch September 8, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mvpratt mvpratt mvpratt approved these changes

@unclerom unclerom unclerom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Tests for the WalletProvider

6 participants

@bootsboogie @mvpratt @unclerom @420coupe @iganbold @elmutt