feat: use WarningAcknowledgement component#6647
Merged
0xApotheosis merged 58 commits intodevelopfrom Apr 16, 2024
Merged
Conversation
* add bottom sheet dialog * try out vaul * hook up send * Create SubPage.tsx * adjusting dialog header * Update DialogCloseButton.tsx * add new action menu * updates * update more height stuff * use 100dvh instead of vh * use 100vh * anchor footer at the bottom of the screen * update new asset search * Update SelectAssets.tsx * add min height for regular modals * Update MobileNavBar.tsx * remove extra stuff not needed for PR * remove more stuff not for this PR * Update AddressInput.tsx * Update AddressInput.tsx * Update Dialog.tsx * Update SelectAssets.tsx * fix for dialog height * Update AssetSearch.tsx --------- Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
* feat: use proxy validation endpoint * chore: improve fn name * update endpoint * fix: csp * fix: tests * chore: use shapeshift proxy csp * chore: fail open --------- Co-authored-by: kaladinlight <35275952+kaladinlight@users.noreply.github.com>
* account down remove portal * Update StepRow.tsx
* chore: invalidate outdated translations * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize --------- Co-authored-by: Hellhound13 <hellhound13@gmx.at> Co-authored-by: Jpanam <jorgepana26@hotmail.com> Co-authored-by: yuki <yuki@beyondclub.xyz> Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com> Co-authored-by: Markus Meyer <djarmy@gmail.com> Co-authored-by: Romko <29romko29@gmail.com> Co-authored-by: tonyjiang12399 <327904087@qq.com>
* feat: getFullAppData tests * feat: cow quote/unsigned order build cleanup
Co-authored-by: GitHub Action <action@github.com>
* fix: zapperAssetToMaybeAssetId handle base-token as native asset * fix: filter unique opportunities by id first * Revert "fix: zapperAssetToMaybeAssetId handle base-token as native asset" This reverts commit 1ed1a59.
* feat: uni-v2 pools static generation * feat: revert DynamicLpAssets flag * feat: regen * feat: cleanup asset upserty bits * feat: regen
0xApotheosis
force-pushed
the
warning-ack
branch
from
c9a3940 to
809d96e
Compare
Update YourPositions.tsx
Member
Author
|
@gomesalexandre & @woodenfurniture all feedback addressed sers 🙏 CI currently failing for unrelated reasons (waiting for my hotfix into |
gomesalexandre
approved these changes
Apr 16, 2024
Contributor
gomesalexandre
left a comment
gomesalexandre
left a comment
There was a problem hiding this comment.
Tackled comments look sane - retested at runtime:
Swapper styles
- Looks sane again! ✅
Swapper unsafe lower than minimum
- Ack is now properly triggered, and captures the original onClick event behavior ✅
unsafe.btc.mov
Swapper Confirm
- Ack is properly triggered, and captures the original onClick event behavior ✅
swapper.confirm.ack.mov
Lending - high-slippage borrow
Wasn't able to retest as both pools are currently halted, though this was previously tested
THORCHain LP
- Ack is properly triggered, and captures the original onClick event behavior ✅
Screen.Recording.2024-04-16.at.12.34.55.mov
Contributor
|
Applying the same patch to invoke unsafe trade quote, the layout is greatly improved but is missing a description of the issue such that it just says "Attention!" without further context 😅
|
woodenfurniture
approved these changes
Apr 16, 2024
Contributor
woodenfurniture
left a comment
woodenfurniture
left a comment
There was a problem hiding this comment.
Fallback text now appearing. Looking good to merge
This was referenced Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for reviewer: use "Hide whitespace" when viewing the diff, and ignore the insane commit history (it was started on the old
developbranch before I fixed it).Description
Adds a new, generic,
WarningAcknowledgementcomponent that can be used across LP, Swapper, and Saver domains to provide a consistent user experience for acknowledging risks associated with a transaction.Wires up this component for the following features/flows:
Still to do (follow-up PR):
Pull Request Type
Issue (if applicable)
Mostly addresses #6605, follow up PR for remaining places to come.
Risk
High. Whilst this PR should only add an additional step in unsafe transaction situations, getting it wrong could mean we break the flow entirely for all of our key revenue generating flows.
Testing
Savers borrow
Use frame to quote a borrow that will result in an unsafe amount of slippage. Upon confirmation of the quote a warning should show.
Not able to test or get a screenshot at time or writing, as borrow is currently halted (cap full).
Monkey patched shot:
Trade quote input
Get a THORChain quote from ETH to BTC, enter about 0.05 ETH and the an unsafe warning should show on preview.
Trade quote confirm
Use frame to confirm a trade that has an unsafe amount of slippage. Upon confirmation of the trade a warning should show.
LP deposit
Use frame to get a quote for a large deposit that cause slippage. Upon confirmation a deposit warning should show.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
high-slippage.mp4