Skip to content

fix: don't render back button on modals initial routes#6675

Merged
woodenfurniture merged 1 commit intodevelopfrom
fix_modals_dont_render_modal_initial_route
Apr 14, 2024
Merged

fix: don't render back button on modals initial routes#6675
woodenfurniture merged 1 commit intodevelopfrom
fix_modals_dont_render_modal_initial_route

Conversation

@gomesalexandre
Copy link
Copy Markdown
Contributor

@gomesalexandre gomesalexandre commented Apr 11, 2024 •
edited
Loading

Description

... regardless of context, since asset selection is always the initial route for

  • Sends (dashboard/asset page)
  • Receives (dashboard/asset page)

Note, QRCode asset selection is a different variant which isn't affected by the removal of the button here, hence still keeps its back functionality unbroken.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6665

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

  • Back button is gone from send modal asset selection step, both in dashboard and asset page
  • Back button is gone from receive modal asset selection step, both in dashboard and asset page
  • Back button is still present in the QR code variant of the asset selection step in dashboard e.g after scanning an EVM address

Engineering

  • ^

Operations

  • ^

Screenshots (if applicable)

Send and Receive asset selection initial step

Screen.Recording.2024-04-12.at.00.10.21.mov

QRCode variant

image

@gomesalexandre gomesalexandre requested a review from a team as a code owner April 11, 2024 22:19
@woodenfurniture woodenfurniture force-pushed the fix_modals_dont_render_modal_initial_route branch from 151c32a to a964cc1 Compare April 14, 2024 21:32
@woodenfurniture woodenfurniture enabled auto-merge (squash) April 14, 2024 21:32
@woodenfurniture woodenfurniture merged commit 617e5d2 into develop Apr 14, 2024
@woodenfurniture woodenfurniture deleted the fix_modals_dont_render_modal_initial_route branch April 14, 2024 21:38
0xApotheosis pushed a commit that referenced this pull request Apr 15, 2024
@gomesalexandre @0xApotheosis
fix: don't render back button on modals initial routes (#6675)
ead8c2e
@0xApotheosis 0xApotheosis mentioned this pull request Apr 16, 2024
Merged
0xApotheosis pushed a commit that referenced this pull request Apr 16, 2024
@gomesalexandre @0xApotheosis
fix: don't render back button on modals initial routes (#6675)
e660d9d
0xApotheosis added a commit that referenced this pull request Apr 16, 2024
@0xApotheosis @woodenfurniture
@gomesalexandre @reallybeard @kaladinlight @firebomb1 @Jpanam @yukiwaki @guiribabrb @MarkusMeyer1 @ByRomko @tonyjiang12399 @actions-user
feat: use WarningAcknowledgement component (#6647)
e6265e7 
* feat: regenerate asset data 04/02/2024 (#6620)

* feat: disable sym deposits after RUNE (#6622)

* fix: don't bork asset generation on idle API failures (#6619)

* feat: collect 0x trade surplus (#6625)

* feat: bottom sheet dialog (#6623)

* add bottom sheet dialog

* try out vaul

* hook up send

* Create SubPage.tsx

* adjusting dialog header

* Update DialogCloseButton.tsx

* add new action menu

* updates

* update more height stuff

* use 100dvh instead of vh

* use 100vh

* anchor footer at the bottom of the screen

* update new asset search

* Update SelectAssets.tsx

* add min height for regular modals

* Update MobileNavBar.tsx

* remove extra stuff not needed for PR

* remove more stuff not for this PR

* Update AddressInput.tsx

* Update AddressInput.tsx

* Update Dialog.tsx

* Update SelectAssets.tsx

* fix for dialog height

* Update AssetSearch.tsx

---------

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>

* chore: use unchained proxy endpoints over nownodes proxy (#6606)

* feat: use proxy validation endpoint (#6626)

* feat: use proxy validation endpoint

* chore: improve fn name

* update endpoint

* fix: csp

* fix: tests

* chore: use shapeshift proxy csp

* chore: fail open

---------

Co-authored-by: kaladinlight <35275952+kaladinlight@users.noreply.github.com>

* feat: many migrations (#6631)

* fix: remove portal on account dropdown (#6635)

* account down remove portal

* Update StepRow.tsx

* feat: cow affiliate fees (#6621)

* chore: update app translations (#6638)

* chore: invalidate outdated translations

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

---------

Co-authored-by: Hellhound13 <hellhound13@gmx.at>
Co-authored-by: Jpanam <jorgepana26@hotmail.com>
Co-authored-by: yuki <yuki@beyondclub.xyz>
Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com>
Co-authored-by: Markus Meyer <djarmy@gmail.com>
Co-authored-by: Romko <29romko29@gmail.com>
Co-authored-by: tonyjiang12399 <327904087@qq.com>

* feat: cow quote/unsigned order build cleanup (#6639)

* feat: getFullAppData tests

* feat: cow quote/unsigned order build cleanup

* fix: deep merge opportunities accounts (#6627)

* feat: regenerate asset data 04/04/2024 (#6636)

Co-authored-by: GitHub Action <action@github.com>

* fix: defi aggregated opportunities uniqBy id first (#6628)

* fix: zapperAssetToMaybeAssetId handle base-token as native asset

* fix: filter unique opportunities by id first

* Revert "fix: zapperAssetToMaybeAssetId handle base-token as native asset"

This reverts commit 1ed1a59.

* feat: lending loan summary repayment lock (#6642)

* fix: mobile dashboard routing (#6637)

* feat: thorchain lp disable max deposits (#6645)

* feat: uni-v2 pools static generation (#6629)

* feat: uni-v2 pools static generation

* feat: revert DynamicLpAssets flag

* feat: regen

* feat: cleanup asset upserty bits

* feat: regen

* feat: regenerate asset data 04/08/2024 (#6648)

* feat: thorchain LP charts (#6624)

* feat: tag foxy as expired opportunity (#6651)

* fix: empty my position pools page (#6656)

Update YourPositions.tsx

* feat: add first pass WarningAcknowledgement component

* chore: use translations

* chore: wire up savers deposit

* chore: tidy

* feat: use warningAcknowledgement in trade quote confirm

* feat: use warningAcknowledgement in trade quote confirm

* feat: use warningAcknowledgement in trade lp deposit

* fix: trade quote input warning logic

* chore: use dimmed background

* chore: component a little closer to mock

* chore: component tweaks

* chore: style fixes

* chore: use cancel translation

* fix: trade confirm warning

* Update WarningAcknowledgement.tsx

* Update WarningAcknowledgement.tsx

* feat: chart styles and loading state (#6655)

* fix: thor token repayments (#6676)

* fix: don't render back button on modals initial routes (#6675)

* chore: use translations & constants

* chore: address review feedback

* fix: unbork trade widget size

* fix: show minimum trade amount when unsafe

* fix: trade confirm width

* chore: trigger CI

* fix: typo

* chore: extract motion style to constant

* fix: add no min fallback message

---------

Co-authored-by: woodenfurniture <125113430+woodenfurniture@users.noreply.github.com>
Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Co-authored-by: reallybeard <89934888+reallybeard@users.noreply.github.com>
Co-authored-by: kevin <35275952+kaladinlight@users.noreply.github.com>
Co-authored-by: firebomb1 <88804546+firebomb1@users.noreply.github.com>
Co-authored-by: Hellhound13 <hellhound13@gmx.at>
Co-authored-by: Jpanam <jorgepana26@hotmail.com>
Co-authored-by: yuki <yuki@beyondclub.xyz>
Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com>
Co-authored-by: Markus Meyer <djarmy@gmail.com>
Co-authored-by: Romko <29romko29@gmail.com>
Co-authored-by: tonyjiang12399 <327904087@qq.com>
Co-authored-by: GitHub Action <action@github.com>
@0xApotheosis 0xApotheosis mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@woodenfurniture woodenfurniture woodenfurniture approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Selecting back arrow on send/receive button on dashboard gives weird grey line

2 participants

@gomesalexandre @woodenfurniture