Skip to content

feat: thorchain LP charts#6624

Merged
gomesalexandre merged 33 commits intodevelopfrom
feat_thor_lp_charts
Apr 9, 2024
Merged

feat: thorchain LP charts#6624
gomesalexandre merged 33 commits intodevelopfrom
feat_thor_lp_charts

Conversation

@gomesalexandre
Copy link
Copy Markdown
Contributor

@gomesalexandre gomesalexandre commented Apr 2, 2024 •
edited
Loading

Description

Brings charts to THORChain LP using tradingview's lightweight-charts.

  • volume charts
  • toggle volume/liquidity charts
  • liquidity charts
  • implement All (or maybe not just yet?)
  • fix types
  • make it look better

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6022

Risk

High Risk PRs Require 2 approvals

Chart data being off mostly

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

  • LP charts data looks sane
  • LP charts look good

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

Screen.Recording.2024-04-02.at.23.02.29.mov

@gomesalexandre Graphite App
Copy link
Copy Markdown
Contributor Author

gomesalexandre commented Apr 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gomesalexandre and the rest of your teammates on Graphite Graphite

@gomesalexandre gomesalexandre changed the title [skip-ci] wip: thorchain LP charts Feat: thorchain LP charts Apr 2, 2024
@gomesalexandre gomesalexandre changed the title Feat: thorchain LP charts feat: thorchain LP charts Apr 2, 2024
@gomesalexandre gomesalexandre marked this pull request as ready for review April 2, 2024 21:05
@gomesalexandre gomesalexandre requested a review from a team as a code owner April 2, 2024 21:05
@gomesalexandre
Copy link
Copy Markdown
Contributor Author

gomesalexandre commented Apr 2, 2024

Opening for a first review.
Data points can definitely be improved there re: the last data point being diff for volume charts depending on the interval used in our THOR request (i.e we use hour interval for "Day" and "Week", but day interval for "Month", and month for "All" - ideally we'd use hour for everything which would give us similar data points but THOR has a limit in the number of intervals they can return.

woodenfurniture
woodenfurniture reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx
woodenfurniture
woodenfurniture reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
woodenfurniture
woodenfurniture reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx
woodenfurniture
woodenfurniture reviewed Apr 8, 2024
View reviewed changes
Comment thread src/components/SimpleChart.tsx Outdated
woodenfurniture
woodenfurniture reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx
woodenfurniture
woodenfurniture approved these changes Apr 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise working super well, just some non-blocking comments and a question about loading state for when the api gets slowww

kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/components/SimpleChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/components/SimpleChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/components/SimpleChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/components/SimpleChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
kaladinlight
kaladinlight reviewed Apr 8, 2024
View reviewed changes
Comment thread src/pages/ThorChainLP/Pool/components/PoolChart.tsx Outdated
@gomesalexandre gomesalexandre enabled auto-merge (squash) April 9, 2024 06:31
@gomesalexandre gomesalexandre merged commit d3f4241 into develop Apr 9, 2024
@gomesalexandre gomesalexandre deleted the feat_thor_lp_charts branch April 9, 2024 12:43
@0xApotheosis 0xApotheosis mentioned this pull request Apr 10, 2024
Closed
0xApotheosis pushed a commit that referenced this pull request Apr 10, 2024
@gomesalexandre @0xApotheosis
feat: thorchain LP charts (#6624)
1894d6c
@0xApotheosis 0xApotheosis mentioned this pull request Apr 10, 2024
Merged
0xApotheosis added a commit that referenced this pull request Apr 10, 2024
@reallybeard @woodenfurniture
@gomesalexandre @0xApotheosis @kaladinlight @firebomb1 @Jpanam @yukiwaki @guiribabrb @MarkusMeyer1 @ByRomko @tonyjiang12399 @actions-user
feat: add watch asset functionality (#6654)
a681d5d 
* add watch asset functionality

* feat: regenerate asset data 04/02/2024 (#6620)

* feat: disable sym deposits after RUNE (#6622)

* fix: don't bork asset generation on idle API failures (#6619)

* feat: collect 0x trade surplus (#6625)

* feat: bottom sheet dialog (#6623)

* add bottom sheet dialog

* try out vaul

* hook up send

* Create SubPage.tsx

* adjusting dialog header

* Update DialogCloseButton.tsx

* add new action menu

* updates

* update more height stuff

* use 100dvh instead of vh

* use 100vh

* anchor footer at the bottom of the screen

* update new asset search

* Update SelectAssets.tsx

* add min height for regular modals

* Update MobileNavBar.tsx

* remove extra stuff not needed for PR

* remove more stuff not for this PR

* Update AddressInput.tsx

* Update AddressInput.tsx

* Update Dialog.tsx

* Update SelectAssets.tsx

* fix for dialog height

* Update AssetSearch.tsx

---------

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>

* chore: use unchained proxy endpoints over nownodes proxy (#6606)

* feat: use proxy validation endpoint (#6626)

* feat: use proxy validation endpoint

* chore: improve fn name

* update endpoint

* fix: csp

* fix: tests

* chore: use shapeshift proxy csp

* chore: fail open

---------

Co-authored-by: kaladinlight <35275952+kaladinlight@users.noreply.github.com>

* feat: many migrations (#6631)

* fix: remove portal on account dropdown (#6635)

* account down remove portal

* Update StepRow.tsx

* feat: cow affiliate fees (#6621)

* chore: update app translations (#6638)

* chore: invalidate outdated translations

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

---------

Co-authored-by: Hellhound13 <hellhound13@gmx.at>
Co-authored-by: Jpanam <jorgepana26@hotmail.com>
Co-authored-by: yuki <yuki@beyondclub.xyz>
Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com>
Co-authored-by: Markus Meyer <djarmy@gmail.com>
Co-authored-by: Romko <29romko29@gmail.com>
Co-authored-by: tonyjiang12399 <327904087@qq.com>

* feat: cow quote/unsigned order build cleanup (#6639)

* feat: getFullAppData tests

* feat: cow quote/unsigned order build cleanup

* fix: deep merge opportunities accounts (#6627)

* feat: regenerate asset data 04/04/2024 (#6636)

Co-authored-by: GitHub Action <action@github.com>

* fix: defi aggregated opportunities uniqBy id first (#6628)

* fix: zapperAssetToMaybeAssetId handle base-token as native asset

* fix: filter unique opportunities by id first

* Revert "fix: zapperAssetToMaybeAssetId handle base-token as native asset"

This reverts commit 1ed1a59.

* feat: lending loan summary repayment lock (#6642)

* fix: mobile dashboard routing (#6637)

* feat: thorchain lp disable max deposits (#6645)

* feat: uni-v2 pools static generation (#6629)

* feat: uni-v2 pools static generation

* feat: revert DynamicLpAssets flag

* feat: regen

* feat: cleanup asset upserty bits

* feat: regen

* feat: regenerate asset data 04/08/2024 (#6648)

* feat: thorchain LP charts (#6624)

* add home page

* trigger ci

* Update AssetActions.tsx

* feat: tag foxy as expired opportunity (#6651)

* fix: empty my position pools page (#6656)

Update YourPositions.tsx

* Update src/pages/Home/Home.tsx

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>

* Update src/state/slices/preferencesSlice/preferencesSlice.ts

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>

* rename to assetIds

* rework the avatar

* more comments

* add top assets default

* feat: naming

---------

Co-authored-by: woodenfurniture <125113430+woodenfurniture@users.noreply.github.com>
Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Co-authored-by: Apotheosis <0xapotheosis@gmail.com>
Co-authored-by: kevin <35275952+kaladinlight@users.noreply.github.com>
Co-authored-by: firebomb1 <88804546+firebomb1@users.noreply.github.com>
Co-authored-by: Hellhound13 <hellhound13@gmx.at>
Co-authored-by: Jpanam <jorgepana26@hotmail.com>
Co-authored-by: yuki <yuki@beyondclub.xyz>
Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com>
Co-authored-by: Markus Meyer <djarmy@gmail.com>
Co-authored-by: Romko <29romko29@gmail.com>
Co-authored-by: tonyjiang12399 <327904087@qq.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Apotheosis <97164662+0xApotheosis@users.noreply.github.com>
0xApotheosis added a commit that referenced this pull request Apr 16, 2024
@0xApotheosis @woodenfurniture
@gomesalexandre @reallybeard @kaladinlight @firebomb1 @Jpanam @yukiwaki @guiribabrb @MarkusMeyer1 @ByRomko @tonyjiang12399 @actions-user
feat: use WarningAcknowledgement component (#6647)
e6265e7 
* feat: regenerate asset data 04/02/2024 (#6620)

* feat: disable sym deposits after RUNE (#6622)

* fix: don't bork asset generation on idle API failures (#6619)

* feat: collect 0x trade surplus (#6625)

* feat: bottom sheet dialog (#6623)

* add bottom sheet dialog

* try out vaul

* hook up send

* Create SubPage.tsx

* adjusting dialog header

* Update DialogCloseButton.tsx

* add new action menu

* updates

* update more height stuff

* use 100dvh instead of vh

* use 100vh

* anchor footer at the bottom of the screen

* update new asset search

* Update SelectAssets.tsx

* add min height for regular modals

* Update MobileNavBar.tsx

* remove extra stuff not needed for PR

* remove more stuff not for this PR

* Update AddressInput.tsx

* Update AddressInput.tsx

* Update Dialog.tsx

* Update SelectAssets.tsx

* fix for dialog height

* Update AssetSearch.tsx

---------

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>

* chore: use unchained proxy endpoints over nownodes proxy (#6606)

* feat: use proxy validation endpoint (#6626)

* feat: use proxy validation endpoint

* chore: improve fn name

* update endpoint

* fix: csp

* fix: tests

* chore: use shapeshift proxy csp

* chore: fail open

---------

Co-authored-by: kaladinlight <35275952+kaladinlight@users.noreply.github.com>

* feat: many migrations (#6631)

* fix: remove portal on account dropdown (#6635)

* account down remove portal

* Update StepRow.tsx

* feat: cow affiliate fees (#6621)

* chore: update app translations (#6638)

* chore: invalidate outdated translations

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

---------

Co-authored-by: Hellhound13 <hellhound13@gmx.at>
Co-authored-by: Jpanam <jorgepana26@hotmail.com>
Co-authored-by: yuki <yuki@beyondclub.xyz>
Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com>
Co-authored-by: Markus Meyer <djarmy@gmail.com>
Co-authored-by: Romko <29romko29@gmail.com>
Co-authored-by: tonyjiang12399 <327904087@qq.com>

* feat: cow quote/unsigned order build cleanup (#6639)

* feat: getFullAppData tests

* feat: cow quote/unsigned order build cleanup

* fix: deep merge opportunities accounts (#6627)

* feat: regenerate asset data 04/04/2024 (#6636)

Co-authored-by: GitHub Action <action@github.com>

* fix: defi aggregated opportunities uniqBy id first (#6628)

* fix: zapperAssetToMaybeAssetId handle base-token as native asset

* fix: filter unique opportunities by id first

* Revert "fix: zapperAssetToMaybeAssetId handle base-token as native asset"

This reverts commit 1ed1a59.

* feat: lending loan summary repayment lock (#6642)

* fix: mobile dashboard routing (#6637)

* feat: thorchain lp disable max deposits (#6645)

* feat: uni-v2 pools static generation (#6629)

* feat: uni-v2 pools static generation

* feat: revert DynamicLpAssets flag

* feat: regen

* feat: cleanup asset upserty bits

* feat: regen

* feat: regenerate asset data 04/08/2024 (#6648)

* feat: thorchain LP charts (#6624)

* feat: tag foxy as expired opportunity (#6651)

* fix: empty my position pools page (#6656)

Update YourPositions.tsx

* feat: add first pass WarningAcknowledgement component

* chore: use translations

* chore: wire up savers deposit

* chore: tidy

* feat: use warningAcknowledgement in trade quote confirm

* feat: use warningAcknowledgement in trade quote confirm

* feat: use warningAcknowledgement in trade lp deposit

* fix: trade quote input warning logic

* chore: use dimmed background

* chore: component a little closer to mock

* chore: component tweaks

* chore: style fixes

* chore: use cancel translation

* fix: trade confirm warning

* Update WarningAcknowledgement.tsx

* Update WarningAcknowledgement.tsx

* feat: chart styles and loading state (#6655)

* fix: thor token repayments (#6676)

* fix: don't render back button on modals initial routes (#6675)

* chore: use translations & constants

* chore: address review feedback

* fix: unbork trade widget size

* fix: show minimum trade amount when unsafe

* fix: trade confirm width

* chore: trigger CI

* fix: typo

* chore: extract motion style to constant

* fix: add no min fallback message

---------

Co-authored-by: woodenfurniture <125113430+woodenfurniture@users.noreply.github.com>
Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Co-authored-by: reallybeard <89934888+reallybeard@users.noreply.github.com>
Co-authored-by: kevin <35275952+kaladinlight@users.noreply.github.com>
Co-authored-by: firebomb1 <88804546+firebomb1@users.noreply.github.com>
Co-authored-by: Hellhound13 <hellhound13@gmx.at>
Co-authored-by: Jpanam <jorgepana26@hotmail.com>
Co-authored-by: yuki <yuki@beyondclub.xyz>
Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com>
Co-authored-by: Markus Meyer <djarmy@gmail.com>
Co-authored-by: Romko <29romko29@gmail.com>
Co-authored-by: tonyjiang12399 <327904087@qq.com>
Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaladinlight kaladinlight kaladinlight approved these changes

@reallybeard reallybeard reallybeard left review comments

+1 more reviewer

@woodenfurniture woodenfurniture woodenfurniture approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beard-oil

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

implement chart for historical pool data

4 participants

@gomesalexandre @kaladinlight @reallybeard @woodenfurniture