PR #2: Implement Keyword Argument Matching Logic #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivasurya
added
enhancement
shivasurya
added
enhancement
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 78.73% 78.76% +0.03%
==========================================
Files 70 70
Lines 6933 6990 +57
==========================================
+ Hits 5459 5506 +47
- Misses 1237 1245 +8
- Partials 237 239 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
This was referenced Nov 21, 2025
Owner
Author
Merge activity
|
shivasurya
changed the base branch from
shiva/pr-01-dsl-ir-extension-keyword-args
to
graphite-base/385
This PR implements the core matching logic that checks CallSite arguments against keyword constraints defined in the IR, making argument checking functional for the first time. Changes: - Modified matchesCallSite() to check both function name and argument constraints - Implemented matchesArguments() to validate keyword argument constraints with AND logic - Implemented matchesArgumentValue() with type-specific matching for strings, booleans, and numbers - Added helper functions: cleanValue(), normalizeValue(), matchesBoolean(), matchesNumber() - Added 12 comprehensive unit tests covering all matching scenarios and edge cases Test Results: - All 12 new tests pass - 100% coverage on matchesArguments(), cleanValue(), matchesBoolean(), matchesNumber() - 89.1% overall coverage on dsl package - No regression in existing tests - Lint passes, build succeeds Stacked on: PR #1 (shiva/pr-01-dsl-ir-extension-keyword-args)
shivasurya
force-pushed
the
shiva/pr-02-keyword-matching-logic
branch
from
50f3c62 to
920a729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the core matching logic for keyword argument validation in the Go executor. The implementation checks both function name patterns and keyword argument values when determining if a call site matches a rule. It supports exact matching and wildcard patterns for argument values, enabling precise detection of security-sensitive function calls with specific parameter configurations.