chore(deps-dev): bump globals from 16.1.0 to 17.6.0 - #1
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
dependabot
Bot
added
dependencies
Bumps [globals](https://github.com/sindresorhus/globals) from 16.1.0 to 17.6.0. - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v16.1.0...v17.6.0) --- updated-dependencies: - dependency-name: globals dependency-version: 17.6.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/globals-17.6.0
branch
from
May 16, 2026 09:47
733c857 to
72751bd
Compare
alsterg
added a commit
that referenced
this pull request
May 22, 2026
Added Gap #1 describing the parser-level pattern → query fallback in NativeToolCallParser.ts, explaining why models confabulate 'pattern' (cross-tool name collision with sed/find_files) and how the fix works without schema pollution. Renumbered existing gaps #2–#7 to #3–#8. chore(release): bump version to 0.22.27
alsterg
added a commit
that referenced
this pull request
May 24, 2026
…apply stats
Bumps shofer extension to 0.24.1.
Prompt clarifications (apply_diff, sed):
- apply_diff: explain that :start_line: is a hint (the engine searches
around it within a buffer window) and that all related edits should
be batched into a single call as multiple SEARCH/REPLACE blocks.
Document the default fuzzy threshold (1.0 / exact match, matching
MultiSearchReplaceDiffStrategy) and the requirement to escape
content lines that look like diff markers (=======, <<<<<<<, >>>>>>>)
with a leading backslash.
- sed: warn that `.` matches any character (the #1 cause of unexpected
replacements, e.g. matching `/`) and document the correct escape
`\.` / `[.]`. Document that `\n` in the JSON-encoded replacement is
decoded to a real newline before `String.replace` runs (the prior
draft incorrectly claimed the opposite).
- native_tools.md: mirror both pitfalls as user-facing callouts.
apply_diff block-level reporting:
- ApplyDiffTool now computes `totalBlocks` / `appliedBlocks` /
`failedBlocks` once and surfaces them to the model via an opaque
`extra` channel on DiffViewProvider.pushToolWriteResult. The model
receives a `diff_stats` struct in the JSON response and a concise
"N/M blocks applied" summary plus a remediation hint when any block
failed ("use read_file to verify the current file state and
re-apply the failed blocks"). Replaces the older absolute-path
`partFailHint` which duplicated the same advice with worse wording.
DiffViewProvider refactor:
- pushToolWriteResult is shared by 9 write tools (apply_diff, sed,
edit, edit_file, write_to_file, insert_edit, search_replace,
apply_patch, ...). The previous attempt at adding block stats
leaked the apply_diff SEARCH/REPLACE format (regex on
`<<<<<<< SEARCH`, knowledge of failParts) into this shared helper.
Replaced with a generic `extra?: { summary?, hint?, stats? }`
parameter; the provider stays format-agnostic and the strategy
parsing lives where it belongs (ApplyDiffTool). Backward-compatible
with all existing 3-arg call sites.
alsterg
added a commit
that referenced
this pull request
May 25, 2026
…omeView hotfix #2) Hotfix #1 (08cb900) relocated `syncExperimentContextKeys` out of `src/shared/experiments.ts` but missed a second offender: `src/shared/ modes.ts` carried `import * as vscode from "vscode"` at line 1, used only by `getAllModesWithPrompts(context: vscode.ExtensionContext)`. `src/shared/modes.ts` is imported by the webview bundle through the `@shofer/shared/modes` alias (see `ExtensionStateContext.tsx`, `SkillsSettings.tsx`, `CreateSkillDialog.tsx`), so the static `vscode` import crashes the webview at module load with: Uncaught TypeError: Failed to resolve module specifier "vscode" …leaving WelcomeView (and every other view) blank with no host-side error. The same pattern bit `vsCodeSelectorUtils.ts`, which used the value form `import { LanguageModelChatSelector } from "vscode"` for a symbol that is only ever used as a type. Fixes: - Move `getAllModesWithPrompts` inline into its only caller, `src/core/prompts/sections/modes.ts` (host-only), with a comment pointing at the Shared Module Isolation Rule in AGENTS.md. - Drop the `vscode` import from `src/shared/modes.ts`. - Convert `vsCodeSelectorUtils.ts` + its spec to `import type` so the symbol is erased at compile time and never appears in the bundle. Bumps to 0.26.12.
alsterg
added a commit
that referenced
this pull request
May 25, 2026
#3) Hotfixes #1 (08cb900) and #2 (09d3858) purged the static `vscode` import from `src/shared/experiments.ts` and `src/shared/modes.ts` respectively. But `src/shared/modes.ts` still re-exported `getFullModeDetails`, which transitively imported `addCustomInstructions` from `src/core/prompts/sections/custom- instructions.ts` — and that module imports `fs/promises`, `path`, and `os`. The webview bundler cannot resolve Node built-ins any more than it can resolve `vscode`, so the webview chunk still carried a stale `shared/modes.ts` source-content reference to a host-only module and the bundle still crashed at load time with `Uncaught TypeError: Failed to resolve module specifier "vscode"` — surfaced this time from the chain modes.ts → custom-instructions.ts. (The reason the symptom looked identical even though the *direct* offender had moved: the cached webview build under `src/webview-ui/build/` was being replayed by turbo because edits to `src/shared/*` did not invalidate the webview package's per-package input hash. Fixed in the superproject by f537a95 which wires `--no-cache` to wipe turbo/vite/tsbuildinfo caches for extension builds. With that flag in hand a clean rebuild confirmed the bundle no longer contains `import "vscode"`.) Fix: move `getFullModeDetails` (the only remaining host-coupled symbol in `src/shared/modes.ts`) into the new host-only module `src/core/modes/getFullModeDetails.ts`, alongside its host-only spec under `src/core/modes/__tests__/getFullModeDetails.test.ts`. Drop the `addCustomInstructions` import from `src/shared/modes.ts`, and strip the now-stale `getFullModeDetails` cases out of the webview-side `src/shared/__tests__/modes.spec.ts`. Update the single host caller in `src/core/environment/getEnvironmentDetails.ts` to import from the new location. Per the "Shared Module Isolation Rule" in AGENTS.md, files under `src/shared/` MUST NOT statically import host-only modules — that includes anything reaching `vscode`, `fs/promises`, `path`, `os`, or host services. This commit closes the last such offender in modes.ts. Bumps version to 0.26.14.
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
alsterg
added a commit
that referenced
this pull request
Jun 10, 2026
…se, clean token set, route diagnostics ✅ #1 (bare-bullet glued case): Changed REASONING_PREAMBLE_RE from /^•\s*response\s*/i to /^•\s*(?:response\s*)?/i so a lone • prefix (glued to real content like '•Okay…') is stripped. Updated UI guard in ReasoningBlock.tsx to match. ✅ Fixed cleanReasoningChunk empty/whitespace handling: the empty check was gated on cleaned !== text, so ''/' ' (unchanged by stripping) returned as-is. Now checks cleaned.trim().length === 0 independently. ✅ #5 (token set reconciliation): Removed 'answer'/'Answer' from LEGACY_ATOMIC_TOKENS — a model's genuine first reasoning chunk could be the word 'answer'. Added 'response' which was already expected by the test. Updated tests to match. ✅ #7 (diagnostics): Removed the bare getOutputChannel() call from deepseek.ts. Both providers now pass diagnosticLog through cleanReasoningChunk's util param using lazy dynamic import (Circular-Import Lazy Logger Rule). Added diagnostic logging to the OpenRouter reasoning_details path. Tests: 28/28 passing (including the previously-failing 6 assertions).
alsterg
added a commit
that referenced
this pull request
Jun 12, 2026
…sks fixes - Mark Known gap #1 (async messages to resumable-but-unloaded peers) as fixed in v1.0.86 — both sync and async modes now rehydrate. - Update 'Target task has no active instance' section with the rehydration flow, sync busy fail-fast, and Form A/B routing. - Update peers scope description to reflect ManagedTask.rootTaskId usage (terminal tasks included, no async history lookups).
alsterg
added a commit
that referenced
this pull request
Jul 7, 2026
…urface) Add plugin-sandbox.ts: createPluginSandbox wraps a full HostBridge into the restricted PluginHost. fs access is scoped to permissions.filesystem (resolved against plugin root + workspace, traversal blocked); fetch is scoped to permissions.network origins; notifier/env pass through. Out-of-scope access is denied (throw + shown/logged warning). Capability wrapper only — no VM/worker isolation (owner decision #1). Export warnPlugin from plugin-manager for reuse.
alsterg
added a commit
that referenced
this pull request
Jul 7, 2026
…ry render The parsedRagSearch and parsedGitSearch useMemo hooks in ChatRow run unconditionally on every message render (React rules-of-hooks). They called raw JSON.parse(message.text), but message.text is only JSON for rag_search_result/git_search_result say types — for every other message (tool results, completion text, status strings) it's a plain string, so the parse threw and logged console.error on every render, flooding the console. Replace the raw JSON.parse + console.error with safeJsonParse<T>(), which is already imported and used 15+ times elsewhere in the same file. It returns undefined on failure instead of throwing; the render cases already handle undefined via optional chaining. Fixes #1 in todos/shofer-ui-known-bugs.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps globals from 16.1.0 to 17.6.0.
Release notes
Sourced from globals's releases.
... (truncated)
Commits
6b1587017.6.000a4dd9Update globals (2026-05-01) (#343)b8170c817.5.05d84602Update globals (2026-04-12) (#342)1b727e5Fix build script for ES globals (#341)a9cfd7417.4.0d43a051Update globals (2026-03-01) (#338)5edc60217.3.0295fba9Update globals (2026-02-01) (#336)8176ac717.2.0