fix(console): join rx_thread in stop() before returning - #610
Merged
chombourger merged 1 commit intoAug 25, 2026
Merged
Conversation
ConsoleOutput.stop() only flipped exiting=True; the rx thread it started in start() could still be alive well after stop() returned, since nothing ever joined it. For RemoteConsole, that thread blocks on a streaming RPC's grpc channel -- a caller that treats stop() as "the channel is gone" and forks right after races grpc-core's own thread pool, which won't report idle to that fork while the channel is still mid-teardown, and stalls with "Waiting for thread pool to idle before forking". ConsoleOutput gains join(timeout=None), and RemoteConsole.stop() calls it after cancelling its stream and closing its channel, so stop() doesn't return until the thread has actually exited. Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
baprusty
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConsoleOutput.stop() only flipped exiting=True; the rx thread it started in start() could still be alive well after stop() returned, since nothing ever joined it. For RemoteConsole, that thread blocks on a streaming RPC's grpc channel -- a caller that treats stop() as "the channel is gone" and forks right after races grpc-core's own thread pool, which won't report idle to that fork while the channel is still mid-teardown, and stalls with "Waiting for thread pool to idle before forking".
ConsoleOutput gains join(timeout=None), and RemoteConsole.stop() calls it after cancelling its stream and closing its channel, so stop() doesn't return until the thread has actually exited.