Fix deployment: No longer use CI windows assets, include about.html #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use the pre-built assets from AppVeyor for our Windows build.
scottnonnenberg
added a commit
that referenced
this pull request
Oct 21, 2017
Load profiles for a conversation without blocking convo load (#1570) The About window is no longer blank (#1564) Add 5s timeout for all requests but attachment up/down, avatar (#1584) Dev: - Move to node fetch API for web requests instead of XHR (#1552) - Log when we've detected a new version (#1567) - Reduce logging when the window moves (#1568) - Add GPLv3 LICENSE file (#1309) - Remove documentation references to BitHub (#1576) - models/conversation: Refer to proper error variable (#1569) - Deployment: No longer use CI windows assets (#1564) - Fix copy pasta of timestamp_m to timestamp_h in locales (#1582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use the assets built on AppVeyor for windows, so we eliminate them from
AppVeyor.yml, thefetch-releaseGrunt task, and thefix_broken_perms.shscript.Also, the new About window shows up as blank in production because
about.htmlis not included in the final build. It's now included.