Remove libp2p multiaddress by jxs · Pull Request #8683 · sigp/lighthouse

jxs · 2026-01-20T14:13:33Z

After a user reported on Discord reported having problems starting Lighthouse with discovery disabled and providing --boot-nodes
I noticed that when a bootnode is provided as ENR lighthouse connects to it directly using libp2p, when a bootnode is a multiaddress it needs to be a UDP multiaddress so that Lighthouse uses Discovery to fetch that node's ENR.
But then later when bootstrapping libp2p, Lighthouse tries to dial those multiaddresses directly from libp2p if they are TCP, thing is, they won't be, as that was not allowed when the config was parsed.
Lighthouse also supports libp2p-nodes config flag that dials the addresses provided in the same way as when providing a valid ENR.

This PR basically removes the --libp2p-nodes flag and uniforms on boot-nodes flag allowing users to pass TCP multiaddresses with the --boot-nodes flag

ackintosh

Thanks @jxs for the cleanup! ✨ Looks good to me.

One small thought: how about having a deprecation period for the --libp2p-nodes flag to preserve CLI compatibility? We usually do this for CLI changes -- keeping the old flag as an alias, emitting a warning when used ( e.g. the --logfile deprecation in #7723).

pawanjay176

This looks clean. I had no idea we accepted multiaddrs in boot-nodes as well.
Agree with @ackintosh about the deprecation instead of delete. I think some existing infra might depend on the flag.

…overy disabled - Filter multiaddrs to only those with UDP and P2P protocols required for discv5 - Add warning when discovery is disabled but discv5-eligible boot-node multiaddrs are provided

ackintosh · 2026-01-26T03:09:05Z

@jxs @pawanjay176 Also, I've filed a PR to improve the UX for the case where a user specifies a UDP multiaddr with --boot-nodes together with --disable-discovery. It would be great if you could take a look when you have some time.

jxs#6

…tosh Filter boot-node multiaddrs for discv5 eligibility

jxs

addressed Akihito's suggestion and re-introduced the flag with deprecation notice, PTAL

ackintosh

Thanks @jxs!

beacon_node/src/config.rs

beacon_node/src/cli.rs

book/src/help_bn.md

Co-authored-by: Akihito Nakano <sora.akatsuki@gmail.com>

mergify · 2026-02-09T16:04:23Z

Some required checks have failed. Could you please take a look @jxs? 🙏

ackintosh

LGTM!

mergify · 2026-02-09T21:45:40Z

Merge Queue Status

Rule: default

✅ Entered queue — 2026-02-09 21:45 UTC
✅ Checks started · on draft merge queue: embarking unstable (f8cfaa4) and #8683 together #8779
🚫 Left the queue — 2026-02-09 21:58 UTC · at 6aa85fb9302b6a5ebce6445ac55d4fd05f9db6cb

This pull request spent 13 minutes 18 seconds in the queue, with no time running CI.

Required conditions to merge

check-success=local-testnet-success
check-success=test-suite-success

Reason

Pull request #8683 has been dequeued by a dequeue command

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

michaelsproul · 2026-02-09T21:57:41Z

@mergify dequeue

mergify · 2026-02-09T21:58:17Z

dequeue

✅ The pull request has been removed from the queue

michaelsproul · 2026-02-09T21:58:21Z

Just quickly dequeueing so I can merge another PR which bypasses mergify:

Merge v8.1.0 (stable) into unstable #8778

Looks like CI for the book might also be failing?

jxs · 2026-02-09T22:04:28Z

Just quickly dequeueing so I can merge another PR which bypasses mergify:

Merge v8.1.0 (stable) into unstable #8778

Looks like CI for the book might also be failing?

yup, thanks Michael. Addressed

michaelsproul · 2026-02-09T22:58:25Z

@mergify queue

mergify · 2026-02-09T22:59:02Z

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 0c9f97f

mergify · 2026-02-09T22:59:03Z

Merge Queue Status

Rule: default

✅ Entered queue — 2026-02-09 22:59 UTC
✅ Checks passed · on draft merge queue: embarking unstable (a3f04bd) and #8683 together #8780
✅ Merged — 2026-02-09 23:31 UTC · at 2d6393568ba932054705163b21b1de858ea1b3ef

This pull request spent 32 minutes 49 seconds in the queue, including 30 minutes 57 seconds running CI.

Required conditions to merge

check-success=local-testnet-success
check-success=test-suite-success

jxs requested review from ackintosh and dknopik January 20, 2026 17:45

remove --libp2p-nodes config and allow tcp multiaddress in --boot-nodes

00b8194

jxs force-pushed the remove-libp2p-multiaddress branch from 694abe9 to 00b8194 Compare January 20, 2026 17:47

ackintosh approved these changes Jan 21, 2026

View reviewed changes

ackintosh added the ready-for-review The code is ready for review label Jan 21, 2026

pawanjay176 approved these changes Jan 23, 2026

View reviewed changes

Filter boot-node multiaddrs for discv5 eligibility and warn when disc…

35ac8af

…overy disabled - Filter multiaddrs to only those with UDP and P2P protocols required for discv5 - Add warning when discovery is disabled but discv5-eligible boot-node multiaddrs are provided

ackintosh mentioned this pull request Jan 26, 2026

Filter boot-node multiaddrs for discv5 eligibility jxs/lighthouse#6

Merged

Merge pull request #6 from ackintosh/remove-libp2p-multiaddress-ackin…

607e41c

…tosh Filter boot-node multiaddrs for discv5 eligibility

jxs commented Jan 29, 2026

View reviewed changes

jxs requested review from ackintosh and pawanjay176 January 29, 2026 12:29

re-introduce flag with deprecated notice

f1b1b81

jxs force-pushed the remove-libp2p-multiaddress branch from 83fd1cd to f1b1b81 Compare January 29, 2026 12:46

ackintosh reviewed Feb 3, 2026

View reviewed changes

beacon_node/src/config.rs Outdated Show resolved Hide resolved

beacon_node/src/cli.rs Outdated Show resolved Hide resolved

book/src/help_bn.md Outdated Show resolved Hide resolved

jxs and others added 3 commits February 9, 2026 15:41

Update book/src/help_bn.md

6410df7

Co-authored-by: Akihito Nakano <sora.akatsuki@gmail.com>

Update beacon_node/src/config.rs

e081d3c

Co-authored-by: Akihito Nakano <sora.akatsuki@gmail.com>

Update beacon_node/src/cli.rs

6aa85fb

Co-authored-by: Akihito Nakano <sora.akatsuki@gmail.com>

jxs requested a review from ackintosh February 9, 2026 15:42

mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Feb 9, 2026

ackintosh approved these changes Feb 9, 2026

View reviewed changes

jxs added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 9, 2026

mergify bot added the queued label Feb 9, 2026

mergify bot added a commit that referenced this pull request Feb 9, 2026

Merge of #8683

7bf78d2

mergify bot mentioned this pull request Feb 9, 2026

merge queue: embarking unstable (f8cfaa4) and #8683 together #8779

Closed

6 tasks

michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Feb 9, 2026

make cli-local

2d63935

mergify bot added dequeued and removed queued labels Feb 9, 2026

mergify bot removed the dequeued label Feb 9, 2026

michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 9, 2026

mergify bot added the queued label Feb 9, 2026

michaelsproul added the backwards-incompat Backwards-incompatible API change label Feb 9, 2026

mergify bot added a commit that referenced this pull request Feb 9, 2026

Merge of #8683

1aa98bb

mergify bot mentioned this pull request Feb 9, 2026

merge queue: embarking unstable (a3f04bd) and #8683 together #8780

Closed

6 tasks

mergify bot merged commit 0c9f97f into sigp:unstable Feb 9, 2026
36 of 37 checks passed

mergify bot removed the queued label Feb 9, 2026

Comments

Conversation

jxs commented Jan 20, 2026

Uh oh!

ackintosh left a comment

Choose a reason for hiding this comment

Uh oh!

pawanjay176 left a comment

Choose a reason for hiding this comment

Uh oh!

ackintosh commented Jan 26, 2026

Uh oh!

jxs left a comment

Choose a reason for hiding this comment

Uh oh!

ackintosh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Feb 9, 2026

Uh oh!

ackintosh left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

michaelsproul commented Feb 9, 2026

Uh oh!

mergify bot commented Feb 9, 2026

✅ The pull request has been removed from the queue

Uh oh!

michaelsproul commented Feb 9, 2026

Uh oh!

jxs commented Feb 9, 2026

Uh oh!

michaelsproul commented Feb 9, 2026

Uh oh!

mergify bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ The pull request has been merged automatically

Uh oh!

mergify bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mergify bot commented Feb 9, 2026 •

edited

Loading

mergify bot commented Feb 9, 2026 •

edited

Loading

mergify bot commented Feb 9, 2026 •

edited

Loading