-
Notifications
You must be signed in to change notification settings - Fork 967
Move KZG commitments from payload envelope to payload bid and spec alpha.2 #8725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move KZG commitments from payload envelope to payload bid and spec alpha.2 #8725
Conversation
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
michaelsproul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Gonna work on the nightly tests in a separate PR. It's a bit of a rabbit hole (what we have now is completely broken).
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 1 minute 26 seconds in the queue, with no time running CI. Required conditions to merge
ReasonPull request #8725 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:
HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
@mergify requeue |
☑️ This pull request is already queued |
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 24 minutes 16 seconds in the queue, including 22 minutes 26 seconds running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks HintYou may have to fix your CI before adding the pull request to the queue again. |
|
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Merge Queue Status✅ The pull request has been merged at 45de1c8 This pull request spent 31 minutes 57 seconds in the queue, including 30 minutes 35 seconds running CI. Required conditions to merge
|
ethereum/consensus-specs#4875
Update the payload envelope and bid types for spec v1.7.0-alpha.2
To get the existing tests passing we also update withdrawals logic for v1.7.0-alpha.2. New SSZ tests for the Gloas block body and execution payload bid types are also added.