Skip to content

Conversation

@eserilev
Copy link
Member

@eserilev eserilev commented Jan 30, 2026

ethereum/consensus-specs#4875

Update the payload envelope and bid types for spec v1.7.0-alpha.2

To get the existing tests passing we also update withdrawals logic for v1.7.0-alpha.2. New SSZ tests for the Gloas block body and execution payload bid types are also added.

@eserilev eserilev requested a review from jxs as a code owner January 30, 2026 05:21
@eserilev eserilev added ready-for-review The code is ready for review gloas labels Jan 30, 2026
@mergify
Copy link

mergify bot commented Jan 30, 2026

Some required checks have failed. Could you please take a look @eserilev? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 30, 2026
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 30, 2026
@mergify
Copy link

mergify bot commented Jan 30, 2026

Some required checks have failed. Could you please take a look @eserilev? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 30, 2026
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 30, 2026
@eserilev eserilev mentioned this pull request Jan 31, 2026
18 tasks
@mergify
Copy link

mergify bot commented Feb 3, 2026

Some required checks have failed. Could you please take a look @eserilev? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Feb 3, 2026
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Gonna work on the nightly tests in a separate PR. It's a bit of a rabbit hole (what we have now is completely broken).

@michaelsproul michaelsproul changed the title Move KZG commitments from payload envelope to payload bid Move KZG commitments from payload envelope to payload bid and spec alpha.2 Feb 4, 2026
@mergify mergify bot added the queued label Feb 4, 2026
@mergify
Copy link

mergify bot commented Feb 4, 2026

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at a14a647

This pull request spent 1 minute 26 seconds in the queue, with no time running CI.
The checks were run on draft #8746.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

Reason

Pull request #8725 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • label=ready-for-merge

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@michaelsproul michaelsproul removed the ready-for-merge This PR is ready to merge. label Feb 4, 2026
mergify bot added a commit that referenced this pull request Feb 4, 2026
@mergify mergify bot added dequeued and removed queued labels Feb 4, 2026
@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Feb 4, 2026
@michaelsproul
Copy link
Member

@mergify requeue

@mergify mergify bot added the queued label Feb 4, 2026
@mergify
Copy link

mergify bot commented Feb 4, 2026

requeue

☑️ This pull request is already queued

@mergify
Copy link

mergify bot commented Feb 4, 2026

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at a14a647

This pull request spent 24 minutes 16 seconds in the queue, including 22 minutes 26 seconds running CI.
The checks were run on draft #8747.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the dequeued label Feb 4, 2026
mergify bot added a commit that referenced this pull request Feb 4, 2026
@mergify mergify bot added dequeued and removed queued labels Feb 4, 2026
@mergify mergify bot removed the dequeued label Feb 4, 2026
@michaelsproul
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Feb 4, 2026

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link

mergify bot commented Feb 4, 2026

Merge Queue Status

✅ The pull request has been merged at 45de1c8

This pull request spent 31 minutes 57 seconds in the queue, including 30 minutes 35 seconds running CI.
The checks were run on draft #8751.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

@mergify mergify bot added the queued label Feb 4, 2026
mergify bot added a commit that referenced this pull request Feb 4, 2026
@mergify mergify bot merged commit 39727aa into sigp:unstable Feb 4, 2026
36 checks passed
@mergify mergify bot removed the queued label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gloas ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants