Skip to content

Comments

Remove kzg_commitments from DataColumnSidecarGloas#8739

Merged
mergify[bot] merged 20 commits intosigp:unstablefrom
jimmygchen:refactor-gloas-remove-kzg-commitments
Feb 4, 2026
Merged

Remove kzg_commitments from DataColumnSidecarGloas#8739
mergify[bot] merged 20 commits intosigp:unstablefrom
jimmygchen:refactor-gloas-remove-kzg-commitments

Conversation

@jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Feb 3, 2026

Description

Aligns DataColumnSidecarGloas with the Gloas spec (EIP-7732) by removing the kzg_commitments field. In Gloas, commitments come from block.body.signed_execution_payload_bid.message.blob_kzg_commitments instead of being embedded in the sidecar.

@jimmygchen jimmygchen changed the title Remove kzg_commitments from DataColumnSidecarGloas Remove kzg_commitments from DataColumnSidecarGloas Feb 3, 2026
@jimmygchen jimmygchen marked this pull request as ready for review February 4, 2026 00:12
@jimmygchen jimmygchen requested a review from jxs as a code owner February 4, 2026 00:12
@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Feb 4, 2026
@mergify
Copy link

mergify bot commented Feb 4, 2026

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Feb 4, 2026
@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 4, 2026
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch

@michaelsproul
Copy link
Member

@mergify queue

@mergify
Copy link

mergify bot commented Feb 4, 2026

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 1dd0f7b

@mergify
Copy link

mergify bot commented Feb 4, 2026

Merge Queue Status

✅ The pull request has been merged at 51caea1

This pull request spent 31 minutes 51 seconds in the queue, including 30 minutes 22 seconds running CI.
The checks were run on draft #8752.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

@mergify mergify bot added the queued label Feb 4, 2026
mergify bot added a commit that referenced this pull request Feb 4, 2026
@mergify mergify bot merged commit 1dd0f7b into sigp:unstable Feb 4, 2026
35 checks passed
@mergify mergify bot removed the queued label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gloas ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants