Skip to content

Gloas bid and preference verification#9036

Merged
mergify[bot] merged 31 commits intosigp:unstablefrom
eserilev:gloas-bid-and-preference-verification
Apr 14, 2026
Merged

Gloas bid and preference verification#9036
mergify[bot] merged 31 commits intosigp:unstablefrom
eserilev:gloas-bid-and-preference-verification

Conversation

@eserilev
Copy link
Copy Markdown
Member

@eserilev eserilev commented Mar 26, 2026

Issue Addressed

Gossip verify and cache bids and proposer preferences. This PR also ensures we subscribe to new fork topics one epoch early instead of two slots early. This is required for proposer preferences.

@eserilev eserilev requested a review from jxs as a code owner March 26, 2026 11:47
@eserilev eserilev added ready-for-review The code is ready for review gloas labels Mar 26, 2026
@eserilev eserilev mentioned this pull request Mar 26, 2026
Open
40 tasks
@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 26, 2026

Some required checks have failed. Could you please take a look @eserilev? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Mar 26, 2026
@mergify mergify Bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Mar 29, 2026
jimmygchen
jimmygchen previously requested changes Mar 31, 2026
View reviewed changes
Comment thread beacon_node/network/src/network_beacon_processor/gossip_methods.rs Outdated
Comment thread beacon_node/network/src/network_beacon_processor/gossip_methods.rs Outdated
Comment thread ...e/beacon_chain/src/proposer_preferences_verification/gossip_verified_proposer_preferences.rs Outdated
Comment thread beacon_node/beacon_chain/src/payload_bid_verification/tests.rs Outdated
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Mar 31, 2026
@eserilev
Copy link
Copy Markdown
Member Author

eserilev commented Apr 1, 2026

resolved feedback and also added kzg commtiment len check on bids as part of this spec PR
ethereum/consensus-specs#5056

@eserilev eserilev added the ready-for-review The code is ready for review label Apr 1, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 12, 2026

Some required checks have failed. Could you please take a look @eserilev? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 12, 2026
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 13, 2026
pawanjay176
pawanjay176 reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is almost good. Great tests on this one!

Comment thread beacon_node/beacon_chain/src/payload_bid_verification/gossip_verified_bid.rs
Comment thread consensus/types/src/state/beacon_state.rs
pawanjay176
pawanjay176 approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this in! 🚀

@pawanjay176 pawanjay176 added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 14, 2026
@pawanjay176 pawanjay176 dismissed jimmygchen’s stale review April 14, 2026 15:58

Addressed all issues

@mergify mergify Bot added the queued label Apr 14, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 14, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 34 minutes 43 seconds in the queue, including 32 minutes 27 seconds running CI.

Required conditions to merge

mergify Bot added a commit that referenced this pull request Apr 14, 2026
@mergify
Merge of #9036
58dd980
@mergify mergify Bot mentioned this pull request Apr 14, 2026
Closed
10 tasks
mergify Bot added a commit that referenced this pull request Apr 14, 2026
@mergify
Merge of #9036
42e3025
@mergify mergify Bot merged commit b40a178 into sigp:unstable Apr 14, 2026
39 checks passed
@mergify mergify Bot removed the queued label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

@jimmygchen jimmygchen jimmygchen left review comments

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees

No one assigned

Labels

gloas ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eserilev @jimmygchen @pawanjay176