Truncated Display impl for ExecutionBlockHash#9108
Truncated Display impl for ExecutionBlockHash#9108mergify[bot] merged 4 commits intosigp:unstablefrom
Display impl for ExecutionBlockHash#9108Conversation
| } | ||
| } | ||
|
|
||
| impl fmt::Display for ExecutionBlockHash { |
There was a problem hiding this comment.
Moving this here because this is just under impl fmt::Debug for ExecutionBlockHash so I thought it would be cleaner this way
macladson
left a comment
There was a problem hiding this comment.
I like the idea of this PR and the new Display impl is good, but I think the implementation is a bit overzealous. I think this PR would be better as a targeted "truncated Display impl for ExecutionBlockHash" PR.
|
If I understand you correctly, we keep others logs unchanged and just changed the impl for
i.e., only the
|
Display impl for ExecutionBlockHash
Merge Queue Status
This pull request spent 29 minutes 40 seconds in the queue, including 27 minutes 31 seconds running CI. Required conditions to merge
|
Issue Addressed
Proposed Changes
The intention is to only modify the INFO logs that's emitted regularly to reduce the verbosity. But I understand that this change will affect other display in the logs too that uses the
ExecutionBlockHashdisplay. So would love some feedbacks about the change.Additional Info
Before:
Apr 08 10:42:17.000 INFO Synced peers: "30", exec_hash: "0x34b19d1c1e27a6da19e0cd1e399aa6be25e79844558a90ad725a3d7f7555a957 (unverified)", finalized_root: 0x7d486be7f3979e50952e45f3d55b52bb0467e7defad79aa3ad9443d8da092749, finalized_epoch: 439560, epoch: 439562, block: "0x8135c79dc63ec70bdf890b1040282ac8d12743d10a44858990d0024c2726189c", slot: 14066009After:
Apr 08 11:17:17.000 INFO Synced peers: "37", exec_hash: "0xf9d6…4778 (unverified)", finalized_root: 0x2e01…5ff9, finalized_epoch: 439566, epoch: 439568, block: "0xf7c5…afee", slot: 14066184