Fix slasher OOM#9141
Merged
mergify[bot] merged 4 commits intosigp:unstablefrom Apr 20, 2026
Merged
Conversation
jimmygchen
reviewed
Apr 16, 2026
| validator_index, | ||
| "Dropping slasher attestation with out-of-range validator index" | ||
| ); | ||
| continue; |
Member
There was a problem hiding this comment.
nit: This loop is in acending validator_index right? would we want to break here if it happens?
Member
Author
There was a problem hiding this comment.
Good catch! Yeah it's a BTreeMap so a break makes sense
jimmygchen
reviewed
Apr 16, 2026
Member
jimmygchen
left a comment
There was a problem hiding this comment.
Looks good and nice test!
Just a minor question on continue.
pawanjay176
approved these changes
Apr 16, 2026
jimmygchen
approved these changes
Apr 20, 2026
Merge Queue Status
This pull request spent 26 minutes 38 seconds in the queue, including 26 minutes 19 seconds running CI. Required conditions to merge
|
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix a vulnerability in the slasher whereby it would OOM upon processing an invalid attestation with an artificially high
validator_index. This fix has already been made available to affected users on theslasher-fixbranch.Proposed Changes