Rust 1.95 lints#9142
Merged
mergify[bot] merged 4 commits intosigp:unstablefrom Apr 16, 2026
Merged
Conversation
macladson
approved these changes
Apr 16, 2026
michaelsproul
approved these changes
Apr 16, 2026
Member
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM. Happy to merge and we can come back to fix the UI API (or delete it) in a separate PR
| }; | ||
| let attestation_hit_percentage: f64 = (100 * attestation_hits) | ||
| .checked_div(attestations) | ||
| .map(|f| f as f64) |
Member
There was a problem hiding this comment.
Separately: isn't this completely pointless? We calculate an integer percentage and then cast it to a float haha
Member
Author
There was a problem hiding this comment.
Lol true. I assumed precision isn't really a requirement but we need it to be f64 somewhere else haha
Merge Queue Status
This pull request spent 28 minutes 54 seconds in the queue, including 26 minutes 26 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Adds lints for rust 1.95. Mostly cosmetic.