Skip to content

Make proposer_score_boost non-optional in ChainSpec#9386

Merged
mergify[bot] merged 1 commit into
sigp:unstablefrom
dapplion:claude-lh-proposer-boost-non-optional-v2
Jun 1, 2026
Merged

Make proposer_score_boost non-optional in ChainSpec#9386
mergify[bot] merged 1 commit into
sigp:unstablefrom
dapplion:claude-lh-proposer-boost-non-optional-v2

Conversation

@dapplion
Copy link
Copy Markdown
Collaborator

@dapplion dapplion commented Jun 1, 2026

Description

Make ChainSpec.proposer_score_boost non-optional (Option<u64>u64), per @michaelsproul's suggestion. Proposer boost is always present on real networks, so the Option only encoded a never-used "no boost" code path. The on-disk config YAML field stays optional and falls back to the base spec when omitted.

Additional Info

🤖 This PR was authored by Claude Code.

Change ChainSpec.proposer_score_boost from Option<u64> to u64. Proposer
boost is always present on real networks (40), so the optionality only
encoded a never-used 'no boost' path. The on-disk Config YAML field stays
optional and falls back to the base spec when omitted.
@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality labels Jun 1, 2026
Copy link
Copy Markdown
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 1, 2026
@mergify mergify Bot added the queued label Jun 1, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 1, 2026

Merge Queue Status

This pull request spent 29 minutes 52 seconds in the queue, including 27 minutes 51 seconds running CI.

Required conditions to merge

mergify Bot added a commit that referenced this pull request Jun 1, 2026
@mergify mergify Bot merged commit cf259e7 into sigp:unstable Jun 1, 2026
38 checks passed
@mergify mergify Bot removed the queued label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants