Skip to content

Fix LT-22611: Allow Bulk Edit Inflection Features for affixes#1018

Merged
jtmaxwell3 merged 2 commits into
mainfrom
LT-22611
Jul 22, 2026
Merged

Fix LT-22611: Allow Bulk Edit Inflection Features for affixes#1018
jtmaxwell3 merged 2 commits into
mainfrom
LT-22611

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

This fixes https://jira.sil.org/browse/LT-22611. We can't just set the inflection features of the MSA since it may be shared with other lexical senses. So we make a copy of the MSA and set its inflection features. We then see whether there is an existing MSA that matches it. If there is, then we use it and delete the copy.

I added code for deleting newFsTarget if it was created by FillInBlanks and it isn't used elsewhere.


This change is Reviewable

@github-actions

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   10m 13s ⏱️ -35s
4 306 tests ±0  4 233 ✅ ±0  73 💤 ±0  0 ❌ ±0 
4 315 runs  ±0  4 242 ✅ ±0  73 💤 ±0  0 ❌ ±0 

Results for commit 907f070. ± Comparison against base commit 9b7d537.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.98%. Comparing base (b30d631) to head (907f070).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Src/FdoUi/InflectionFeatureEditor.cs 0.00% 32 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
- Coverage   32.99%   32.98%   -0.01%     
==========================================
  Files        1202     1202              
  Lines      278175   278248      +73     
  Branches    37152    37169      +17     
==========================================
+ Hits        91781    91788       +7     
- Misses     158543   158593      +50     
- Partials    27851    27867      +16     
Files with missing lines Coverage Δ
Src/FdoUi/InflectionFeatureEditor.cs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-sil mark-sil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).

@jtmaxwell3
jtmaxwell3 merged commit 2e3576f into main Jul 22, 2026
7 checks passed
@jtmaxwell3
jtmaxwell3 deleted the LT-22611 branch July 22, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants