Skip to content

Fix LT-22609: Crash creating New Project with trailing space#1022

Merged
thejambi merged 2 commits into
mainfrom
bugfix/LT-22609
Jul 22, 2026
Merged

Fix LT-22609: Crash creating New Project with trailing space#1022
thejambi merged 2 commits into
mainfrom
bugfix/LT-22609

Conversation

@thejambi

@thejambi thejambi commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

LT0-22609. Trimming project name before file creation to fix the issue. Added FwNewLangProjectModel_ProjectName_TrimsSurroundingWhitespace tests to ensure project name leading or trailing spaces are trimmed.

Quick Summary

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md (subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).
  • No whitespace warnings locally:
    git fetch origin
    git log --check --pretty=format:"---% h% s" origin/<base>..
    git diff --check --cached
  • Builds/tests pass locally (or I've run the CI-style build via Bash script or MSBuild).
  • If this is core-developer AI-assisted work, I followed Docs/workflows/ai-pr-workflow.md and ran pr-preflight or the equivalent branch-readiness review before requesting review.
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate.

Notes for reviewers (optional)


This change is Reviewable

[LT0-22609](https://jira.sil.org/browse/LT-22609).
Trimming project name before file creation to fix the issue.
Added FwNewLangProjectModel_ProjectName_TrimsSurroundingWhitespace tests
to ensure project name leading or trailing spaces are trimmed.
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   9m 52s ⏱️ -42s
4 313 tests +6  4 240 ✅ +6  73 💤 ±0  0 ❌ ±0 
4 322 runs  +6  4 249 ✅ +6  73 💤 ±0  0 ❌ ±0 

Results for commit 7fb8924. ± Comparison against base commit 6b15ecc.

♻️ This comment has been updated with latest results.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.03%. Comparing base (6b15ecc) to head (69816c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   33.03%   33.03%           
=======================================
  Files        1202     1202           
  Lines      278193   278193           
  Branches    37159    37160    +1     
=======================================
+ Hits        91889    91894    +5     
+ Misses     158465   158461    -4     
+ Partials    27839    27838    -1     
Files with missing lines Coverage Δ
Src/FwCoreDlgs/FwNewLangProjectModel.cs 79.59% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-sil mark-sil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on thejambi).

Comment thread Src/FwCoreDlgs/FwCoreDlgsTests/FwNewLangProjectModelTests.cs Outdated
Comment thread Src/FwCoreDlgs/FwCoreDlgsTests/FwNewLangProjectModelTests.cs Outdated
Comment thread Src/FwCoreDlgs/FwCoreDlgsTests/FwNewLangProjectModelTests.cs Outdated
@thejambi
thejambi requested a review from mark-sil July 22, 2026 13:22
@thejambi
thejambi merged commit 7176e6c into main Jul 22, 2026
6 of 7 checks passed
@thejambi
thejambi deleted the bugfix/LT-22609 branch July 22, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants