LT-22686: Hide UI switching behind FW_AVALONIA environment variable - #1068
Merged
Conversation
* Update Set-FieldWorksLegacyMode.ps1 to honor this * Also clean up some old comments Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
=======================================
Coverage 38.04% 38.05%
=======================================
Files 1499 1499
Lines 350108 350127 +19
Branches 40231 40239 +8
=======================================
+ Hits 133216 133231 +15
- Misses 187607 187609 +2
- Partials 29285 29287 +2
🚀 New features to boost your workflow:
|
papeh
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an environment variable FW_AVALONIA and treats any value except 0, false, or off as opting in. Non-existance of the environment variable is also opt-out.
When opted out the setting for turning on the New mode is ignored and the options dialog choice is not there.
Set-FieldWorksLegacyMode.ps1 which is used for testing now takes this into account.
Why - we want people to opt in to UI switching rather than have it available to everyone while early work and decision-making are still in progress.
Verification - build clean; FwUtilsTests 389/389, xWorksTests 1475 passed/2 skipped, LexTextControlsTests 349 passed/3 skipped.
Not covered by tests - the gate-closed paths (persisted
Newseeding Legacy, the group not being built, OK preserving the persisted mode) are verified by inspection only; the value rule itself is pinned by unit tests.🤖 Generated with Claude Code
This change is