Skip to content

Cleanup comments - #1120

Merged
jasonleenaylor merged 1 commit into
mainfrom
cleanup-gear-menu-comments
Sep 2, 2026
Merged

Cleanup comments#1120
jasonleenaylor merged 1 commit into
mainfrom
cleanup-gear-menu-comments

Conversation

@mark-sil

@mark-sil mark-sil commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Eight comments across six files described the detail row's field menu as a "gear menu". There is no gear anywhere: it is a blue down-arrow in the legacy view and a three-dot button in Avalonia. They now say "menu-button", the term already used in LT-17670 and LT-19150 — which also stops the wrong word being copied into new comments.

Comments only. No executable code changed, so the build is the gate here; it validates the <see cref> references in the doc comments, and there is nothing for tests to exercise.

The diff is a little larger than eight word swaps. "menu-button" is two characters longer than "gear-menu", which pushed five lines past the width limit and tripped the comment-hygiene auto-rewrap, stranding single words ("composed", "view", "restores", "layout's", "change") on their own lines. Those blocks are hand-rewrapped so the prose reads normally and stays under the limit.

One further occurrence, the log message in RecordEditView.Avalonia.cs, is deliberately absent: it is already fixed in #1119, and touching it here would conflict.


This change is Reviewable

There is no "gear-menu" in the product, so eight comments change the wording to
"menu-button", which also stops AI from copying "gear-menu" into new comments.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   12m 9s ⏱️ + 4m 5s
5 996 tests ±0  5 915 ✅ +1  81 💤 ±0  0 ❌  - 1 
6 005 runs  ±0  5 924 ✅ +1  81 💤 ±0  0 ❌  - 1 

Results for commit 2862b4b. ± Comparison against base commit 8f46a80.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.55%. Comparing base (8f46a80) to head (2862b4b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
- Coverage   38.55%   38.55%   -0.01%     
==========================================
  Files        1513     1513              
  Lines      350968   350968              
  Branches    40345    40345              
==========================================
- Hits       135322   135308      -14     
- Misses     186429   186444      +15     
+ Partials    29217    29216       -1     
Files with missing lines Coverage Δ
Src/Common/FwAvalonia/Detail/DetailModel.cs 77.95% <ø> (ø)
...nia/ViewDefinition/ViewDefinitionOverrideEditor.cs 88.54% <ø> (ø)
Src/xWorks/Avalonia/Composer/DetailComposer.cs 67.41% <ø> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasonleenaylor
jasonleenaylor merged commit d82718b into main Sep 2, 2026
8 checks passed
@jasonleenaylor
jasonleenaylor deleted the cleanup-gear-menu-comments branch September 2, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants