fix(uploads): fix Azure Blob connection-string-only auth and document self-host parity#5553
Conversation
… self-host parity Every Azure Blob operation (upload/download/delete/head/presigned URLs) threw when only AZURE_CONNECTION_STRING was set, despite that being the documented alternative to AZURE_ACCOUNT_NAME/KEY across .env.example, env.ts, and the Helm chart. createBlobConfig required accountName unconditionally, and the upload-SAS path had no fallback to derive credentials from the connection string. Fixed both, verified end-to-end against a live Azurite emulator (upload, download, head, delete, multipart/block-blob upload, and real HTTP PUT/GET through generated SAS URLs), and added regression tests. Also closes the remaining self-host Azure documentation gaps: AZURE_ACS_CONNECTION_STRING, OCR_AZURE_*, KB_OPENAI_MODEL_NAME, and WAND_OPENAI_MODEL_NAME are now documented in the Helm chart (values.yaml, values.schema.json, values-azure.yaml) and .env.example alongside their AWS/S3 counterparts.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Storage behavior: Docs / Helm: Reviewed by Cursor Bugbot for commit eeffe55. Configure here. |
Greptile SummaryThis PR fixes Azure Blob connection-string auth and updates Azure self-host documentation. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(uploads): map new Azure keys in the ..." | Re-trigger Greptile |
Greptile flagged that the values-azure.yaml External Secrets example didn't map KB_OPENAI_MODEL_NAME, WAND_OPENAI_MODEL_NAME, OCR_AZURE_ENDPOINT, and OCR_AZURE_MODEL_NAME, so a user who fills those in and switches to ESO would hit a Helm template render failure. Added the remoteRefs entries and verified with an isolated helm template render.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit eeffe55. Configure here.
Summary
AZURE_CONNECTION_STRINGwas set — even though that's the documented alternative toAZURE_ACCOUNT_NAME/AZURE_ACCOUNT_KEYacross.env.example,env.ts, and the Helm chart.env.example:AZURE_ACS_CONNECTION_STRING(email),OCR_AZURE_*(OCR),KB_OPENAI_MODEL_NAME,WAND_OPENAI_MODEL_NAMEType of Change
Testing
bun run type-check,biome check,bun run vitest run lib/uploads/(127/127 passing) all cleanhelm lint+helm templateagainst base chart and Azure example profilebun run check:api-validationpassesChecklist