fix(security): close code-scanning and dependabot alerts by waleedlatif1 · Pull Request #5557 · simstudioai/sim

waleedlatif1 · 2026-07-10T03:33:37Z

Summary

markdown-paste.ts: strip <style>/<script> in a loop instead of a single pass, so nested/overlapping tags can't leave a surviving <script> behind (CodeQL: incomplete multi-character sanitization)
block-identity.ts: annotate the two SHA-1 uses as intentional (UUIDv5 per RFC 4122, deterministic id derivation only — not a security use of the hash) instead of swapping algorithms, which would change every derived fork block id and break existing webhook URLs
apps/pii: bump transformers 4.56.2 -> 5.3.0 (CVE-2026-4372 RCE via crafted config.json, CVE-2026-1839 RCE via Trainer's torch.load), huggingface_hub 0.35.3 -> 1.3.0 (transformers 5.3.0's floor), pytest 8.4.1 -> 9.0.3 (CVE-2025-71176 tmpdir handling)

Type of Change

Bug fix / security

Testing

Verified pip resolves the new apps/pii pins cleanly (no conflicts) in a clean python:3.12-slim container
Ran the apps/pii unit test suite against pytest 9.0.3 — passes
bunx biome check clean on both touched TS files

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

- markdown-paste.ts: strip <style>/<script> in a loop, not a single pass, so nested/overlapping tags can't leave a surviving <script> behind (incomplete multi-character sanitization) - block-identity.ts: annotate the two SHA-1 uses as intentional (UUIDv5 per RFC 4122, deterministic id derivation only, not a security use of the hash) rather than swap algorithms, which would change every derived fork block id - apps/pii: bump transformers 4.56.2 -> 5.3.0 (CVE-2026-4372 RCE via crafted config.json, CVE-2026-1839 RCE via Trainer torch.load), huggingface_hub 0.35.3 -> 1.3.0 (transformers 5.3.0's floor), and pytest 8.4.1 -> 9.0.3 (CVE-2025-71176 tmpdir handling); verified pip resolves cleanly and the unit test suite passes on 9.0.3

vercel · 2026-07-10T03:33:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 10, 2026 3:49am

cursor · 2026-07-10T03:33:47Z

PR Summary

Medium Risk
Paste sanitization touches attacker-controlled clipboard HTML in the editor; dependency bumps affect the PII GLiNER image and should be validated in that runtime, but fork identity and hashing behavior are unchanged.

Overview
Addresses CodeQL, static-analysis, and dependency CVE findings without changing fork block-id behavior.

Rich markdown paste: stripNonContentHtml no longer uses one-shot regex removal of <style>/<script> pairs. It scans open/close tag tokens in a single pass with nesting depth, so nested or overlapping tags cannot leave a surviving <script>, and unterminated tags drop the element and trailing input instead of leaking content. Tests cover deep nesting and malformed HTML.

Workspace forking: Documents that UUIDv5 SHA-1 in block-identity.ts is RFC-mandated deterministic id derivation (not a security hash) and adds lgtm[js/weak-cryptographic-algorithm] suppressions rather than changing the algorithm, which would break existing fork webhook URLs and block references.

PII service deps: Bumps transformers to 5.3.0 and huggingface_hub to 1.3.0 in the GLiNER image pins, and pytest to 9.0.3 in dev requirements, for known RCE/tmpdir CVE fixes.

^{Reviewed by Cursor Bugbot for commit 55051c4. Configure here.}

greptile-apps · 2026-07-10T03:37:09Z

Greptile Summary

This PR fixes security alerts in the paste sanitizer, fork block IDs, and PII dependency pins. The main changes are:

Reworks <script> and <style> stripping for pasted markdown HTML.
Adds tests for nested, deeply nested, and unterminated non-content tags.
Documents intentional SHA-1 use for UUIDv5 block identity derivation.
Bumps PII service Python dependencies for security updates.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-paste.ts	Replaces repeated non-content HTML replacement with a single-pass tag scanner for pasted content.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-paste.test.ts	Adds tests for nested, deep, and unterminated `<script>` and `<style>` paste inputs.
apps/sim/ee/workspace-forking/lib/remap/block-identity.ts	Adds comments explaining why UUIDv5 keeps SHA-1 for deterministic fork block IDs.
apps/pii/requirements-gliner.txt	Updates the GLiNER-related dependency pins used by the PII service.
apps/pii/requirements-dev.txt	Updates the test dependency pin for the PII service.

_{Reviews (4): Last reviewed commit: "fix(files): drop unterminated <script>/<..." | Re-trigger Greptile}

Greptile flagged the repeated-replace loop from the prior commit: it strips <style>/<script> correctly but rescans the whole string once per nesting level, so deeply nested clipboard HTML can freeze the tab. Replace it with a single linear pass that tracks nesting depth of the open tag via a tag-token scan, dropping the element in one pass no matter how deeply nested.

waleedlatif1 · 2026-07-10T03:39:57Z

@greptile

waleedlatif1 · 2026-07-10T03:39:58Z

@cursor review

Repo convention is TSDoc-only documentation, no non-TSDoc explanatory comments. Moved the uuidV5 SHA-1 rationale and the stray-close-tag note into the existing TSDoc blocks above each function. Left the two lgtm[...] annotations as trailing comments since those are functional CodeQL suppression directives (must sit on the flagged line), not documentation.

waleedlatif1 · 2026-07-10T03:41:20Z

@greptile

waleedlatif1 · 2026-07-10T03:41:21Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

2 issues from previous reviews remain unresolved.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 2ec7bdf. Configure here.}

Covers the case Greptile flagged: nested and 50-deep <script> tags must strip in one pass without leaking a dangling tag.

Cursor Bugbot caught two related bugs in the single-pass rewrite: if pasted HTML ends while a script/style element is still open (truncated or malformed clipboard HTML), cursor never advanced past the open tag, so the final flush re-appended the untouched tag/content (leaking an unstripped <script>) and duplicated the prefix already copied into result. Fix: advance cursor the moment a tag opens, not when it closes, and only do the final flush when we end at depth 0. An element that never closes has cursor already past its open tag, so it and everything after it is dropped instead of reappearing.

waleedlatif1 · 2026-07-10T03:50:11Z

@greptile

waleedlatif1 · 2026-07-10T03:50:12Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 55051c4. Configure here.}

greptile-apps Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread .../workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-paste.ts Outdated

vercel Bot temporarily deployed to Preview July 10, 2026 03:39 Inactive

cursor Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread .../workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-paste.ts

Comment thread .../workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-paste.ts Outdated

vercel Bot temporarily deployed to Preview July 10, 2026 03:41 Inactive

cursor Bot reviewed Jul 10, 2026

View reviewed changes

test(files): lock in nested-tag stripping regression for markdown paste

8b3f9bf

Covers the case Greptile flagged: nested and 50-deep <script> tags must strip in one pass without leaking a dangling tag.

vercel Bot temporarily deployed to Preview July 10, 2026 03:44 Inactive

vercel Bot temporarily deployed to Preview July 10, 2026 03:49 Inactive

cursor Bot reviewed Jul 10, 2026

View reviewed changes

waleedlatif1 merged commit f9a5d8b into staging Jul 10, 2026
16 checks passed

waleedlatif1 deleted the security/code-scanning-dependabot-fixes branch July 10, 2026 03:54

waleedlatif1 mentioned this pull request Jul 10, 2026

v0.7.28: rich markdown editor improvements, autosave in files, helm improvements #5556

Merged

Uh oh!

Conversation

waleedlatif1 commented Jul 10, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

waleedlatif1 commented Jul 10, 2026

Uh oh!

waleedlatif1 commented Jul 10, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 10, 2026

Uh oh!

waleedlatif1 commented Jul 10, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Jul 10, 2026

Uh oh!

waleedlatif1 commented Jul 10, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 10, 2026 •

edited

Loading

cursor Bot commented Jul 10, 2026 •

edited

Loading

greptile-apps Bot commented Jul 10, 2026 •

edited

Loading