improvement(url-state): migrate list search/sort/filter view-state to nuqs#5648
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Knowledge and Files gain typed Logs adds URL-backed Settings consolidates list search into shared Next.js Suspense wraps Account settings renderer and Knowledge page entry where nuqs/ Reviewed by Cursor Bugbot for commit 422cfd4. Configure here. |
Greptile SummaryThis PR moves shareable list view state into URL query params with nuqs. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "fix(url-state): explicit Suspense bounda..." | Re-trigger Greptile |
b38204c to
492e0bd
Compare
|
@cursor review |
…se for detail back navigation
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 422cfd4. Configure here.
Summary
useStateto nuqs URL params across knowledge, files, logs, skills, and settingssearch-params.ts— search, connector/content/owner filters,sort+dir; add the required Suspense boundary on the page entrysearch, nullablesort+dir, and type/size/uploaded-by filter params in a separatehistory: 'replace'group so filter writes never pollute the back stack (folder navigation keepspush)sort+dirparams so sorted views deep-link and fetch correctly on loadsearchparam alongside the existingskillIdworkflow-mcp-serversreadingmcpServerIdviauseSearchParamsintouseState(selection now writes the URL, back closes the detail view); migrate six settings search boxes to nuqs with debounced URL writessettings/components/search-params.tsType of Change
Testing
Typecheck + biome clean; behavior semantics (debounce timing, default sort orderings, folder name/asc fallback in files) preserved exactly
Checklist