fix(landing): align author-page UI with the site shell and link bylines to it#5655
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@cursor review |
PR SummaryLow Risk Overview Post bylines now link to Author URLs in the sitemap and SEO (canonical, JSON-LD) use Reviewed by Cursor Bugbot for commit b593e88. Configure here. |
Greptile SummaryThis PR refreshes the author-page experience and routes post bylines to internal author pages. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (5): Last reviewed commit: "fix(landing): encode author id consisten..." | Re-trigger Greptile |
Greptile SummaryThis PR brings author pages into the standard landing-page shell. The main changes are:
Confidence Score: 5/5This looks safe to merge after a small author-link cleanup.
apps/sim/app/(landing)/components/content-post-page/content-post-page.tsx Important Files Changed
Reviews (2): Last reviewed commit: "fix(landing): align author-page UI with ..." | Re-trigger Greptile |
…es to it
Rebuilds ContentAuthorPage/ContentAuthorLoading to match the standard
page-shell pattern used by ContentIndexPage/ContentPostPage (max-w-[1460px]
header, BackLink, framed post-list rows with hover states) instead of the
previous bare max-w-[900px] container with a 2-column image grid. Adds a
styled not-found fallback matching the comparisons/integrations pattern.
The byline author Link in ContentPostPage now points at the internal
author page (/{basePath}/authors/{id}) instead of the author's external
X/GitHub profile, giving the author page a real navigation entry point for
the first time - previously it was only reachable via the sitemap.
Also fixes both author-page route files to match on any of a post's
authors (post.authors.some(a => a.id === id)) instead of only the primary
author (post.author.id === id), so posts with co-authors show up on every
listed author's page, consistent with the sitemap's own author enumeration.
- Not-found fallback no longer renders a nested <main id='main-content'> - blog/layout.tsx and library/layout.tsx already provide that landmark, so the fallback now uses <section> like the rest of the component. - Byline author link now encodeURIComponent()s the author id before using it as a route segment. - Loading skeleton's post-list wrapper now matches the real page's mx-auto max-w-[1460px] shell (was mx-20/max-lg:mx-8, which stretches past the header on wide viewports).
Same class of bug as the earlier article-image fix: author.avatarUrl is a site-relative path, so Person.image was emitting an invalid relative URL for crawlers. Prefixes with SITE_URL, matching buildArticleJsonLd's existing pattern.
f8d4a92 to
807a7a8
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 807a7a8. Configure here.
…vention max-w-[1446px]/px-12 was copied from comparisons/not-found.tsx, which turns out to be the outlier - models/not-found.tsx and integrations/not-found.tsx both use max-w-[1460px]/px-20, matching the rest of the site's shell and this component's own success-state header.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 760a77f. Configure here.
The byline link encoded the author id, but buildAuthorMetadata's canonical URL, buildAuthorGraphJsonLd's Person.url/BreadcrumbList item, and sitemap.ts's buildAuthorPages URL still interpolated the raw id - a mismatch could point sitemap/canonical/structured-data URLs at a different route than the actual page. All four now encodeURIComponent() consistently.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b593e88. Configure here.
Summary
Type of Change
Testing
bunx tsc --noEmitcleanbun run lintclean/blog/mothershiplinks to/blog/authors/emir/blog/authors/emirand/library/authors/waleedreturn 200 with the rebuilt shellChecklist