Skip to content

fix(settings): restore header shell on workspace credit-usage page#5663

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/credit-usage-settings-shell
Jul 14, 2026
Merged

fix(settings): restore header shell on workspace credit-usage page#5663
waleedlatif1 merged 1 commit into
stagingfrom
fix/credit-usage-settings-shell

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • fixes the workspace settings/billing/credit-usage page rendering with no header, title, or scroll region (user-reported: page "won't scroll")
  • regressed in feat(platform): settings permissions, admin, billing attribution/concurrency lims #5545: CreditUsageView moved from the self-chromed CredentialDetailLayout to SettingsPanel, which only registers header config into SettingsHeaderProvider context — the chrome renders in SettingsHeaderShell
  • the workspace plane mounts that shell in settings/[section]/layout.tsx, but billing/credit-usage is a static route outside [section], so the panel registered into nothing and the page rendered bare children with no scroll container (the account/org planes mount the shell at their settings root, which is why the same view works there)
  • fix: mount SettingsHeaderProvider + SettingsHeaderShell in a route-level layout.tsx for billing/credit-usage, mirroring [section]/layout.tsx; this also covers the route's loading.tsx fallback
  • audited every other SettingsPanel consumer (workspace sections, account/org renderers, ee components) — all render under a shell; this route was the only orphan

Type of Change

  • Bug fix

Testing

Typecheck clean, credit-usage + billing tests pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 14, 2026 2:19am

Request Review

@cursor

cursor Bot commented Jul 14, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single layout wrapper with no auth, billing logic, or data changes—only restores existing settings UI chrome for one route.

Overview
Adds a route-level layout.tsx under settings/billing/credit-usage that wraps the page in SettingsHeaderProvider and SettingsHeaderShell, matching what settings/[section]/layout.tsx already does for other workspace settings sections.

Because credit usage lives outside the [section] segment, it never inherited that chrome after CreditUsageView started using SettingsPanel (header config only). The page rendered without a title bar or scroll container; this layout restores both for the page and its loading state.

Reviewed by Cursor Bugbot for commit 0ce167b. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR restores the settings chrome for the workspace credit-usage page. The main changes are:

  • Adds a route-level layout for settings/billing/credit-usage.
  • Wraps the route in SettingsHeaderProvider and SettingsHeaderShell.
  • Covers both the page content and loading fallback with the same shell.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/billing/credit-usage/layout.tsx Adds the missing settings header provider and shell for the workspace credit-usage route.

Reviews (1): Last reviewed commit: "fix(settings): restore header shell on w..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit e04a4fa into staging Jul 14, 2026
18 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/credit-usage-settings-shell branch July 14, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant