fix(custom-blocks): stop image icons blowing up on class-sized surfaces#5878
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview
Removes the chat subagent tool-row inline Reviewed by Cursor Bugbot for commit 36d78e4. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR corrects custom-block image sizing across inline and tiled icon surfaces. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(custom-blocks): stop image icons blo..." | Re-trigger Greptile |
Summary
size-[14px]) instead of a fixed-size tile wrapper — hit the @-mention dropdown, chat context mention chips, and the files editor mention/slash menusmakeImageIconappended a trailingsize-fullthat won the twMerge conflict against every consumer size class; each surface had to be point-patched with inline styles (like the earlier subagent tool-row fix)size-fullis now only the default and any consumer size class or inline style wins; tile surfaces that want the image to fill (canvas node, toolbar, search modal, editor headers, terminal, trace view, etc.) opt in with[&_img]:size-fullon their fixed wrapper — a missed surface now renders a small icon instead of a page-breaking imageoverflow-hiddento the fill tiles so image corners clip to the tile rounding, brought connection-blocks into the fill contract, sizedimgicons in the files suggestion menus, and reverted the now-unneeded inline-style workaround in the chat tool-call rowType of Change
Testing
Tested manually against a live workspace with a published custom block: @-mention dropdown renders the uploaded icon at 14px, toolbar tile still fills 16px, canvas tile precedence verified at 24px.
lint:check,tsc --noEmit,check:api-validation:strict, and custom-block unit tests all pass.Checklist