Skip to content

fix(knowledge): change "Create Tag" to "Apply Tag" when applying a tag to a document - #6055

Merged
j15z merged 1 commit into
stagingfrom
fix/change-tag-button-wording
Jul 29, 2026
Merged

fix(knowledge): change "Create Tag" to "Apply Tag" when applying a tag to a document#6055
j15z merged 1 commit into
stagingfrom
fix/change-tag-button-wording

Conversation

@j15z

@j15z j15z commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The "apply an existing tag to a document" button in the knowledge base said "Create Tag" (and "Creating..." while pending), same wording as the separate "create a new tag definition" button — confusing since they're different actions
  • Changed the apply-to-document button to say "Apply Tag" / "Applying..."
  • Left the KB-level tag-definition creation button (base-tags-modal.tsx) as "Create Tag" since that one genuinely creates a new tag schema

Type of Change

  • Bug fix

Testing

Tested manually. Ran bun run lint, boundary/API-validation/react-query/zustand/client-boundary/icon/realtime-prune/skills/agent-stream-docs audits — all passing.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jul 29, 2026 6:32pm

Request Review

@cursor

cursor Bot commented Jul 29, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Copy-only UI change in one modal; no behavior, API, or data logic changes.

Overview
Updates the primary button in the document tags modal so applying a tag to a document reads Apply Tag (and Applying... while saveDocumentTag runs), instead of reusing Create Tag / Creating....

KB-level tag definition creation in base-tags-modal is unchanged and still uses Create Tag.

Reviewed by Cursor Bugbot for commit 99e3c59. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the document tags modal apply-to-document button label from "Create Tag"/"Creating..." to "Apply Tag"/"Applying..." so it is distinct from KB-level tag-definition creation.

Confidence Score: 5/5

Safe to merge; the change is a single user-facing label update with no behavioral risk.

Only the apply-tag button copy changes; runtime behavior, data handling, and security paths are untouched.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/components/document-tags-modal/document-tags-modal.tsx Button idle/pending label text only; no logic, API, or state changes.

Reviews (1): Last reviewed commit: "fix(knowledge): change "Create Tag" to "..." | Re-trigger Greptile

@j15z
j15z merged commit 0618541 into staging Jul 29, 2026
27 checks passed
@j15z
j15z deleted the fix/change-tag-button-wording branch July 29, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant