improvement(logfire): scope block outputs per operation and refresh brand chrome - #6178
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Two new block skills ( validate-integration guidance (agents, Claude, Cursor) adds a Regenerate Derived Artifacts section ( Reviewed by Cursor Bugbot for commit 913f067. Configure here. |
Greptile SummaryThe PR refines the Logfire integration’s operation-specific output metadata, token information, timestamp and limit normalization, and visual branding.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/blocks/blocks/logfire.ts | Correctly scopes each declared output to the Logfire operations whose tools return it and updates block branding and templates. |
| apps/sim/tools/logfire/get_token_info.ts | Maps nullable token expiry and spending-cap fields into tool outputs with corresponding metadata. |
| apps/sim/tools/logfire/utils.ts | Preserves hour-only timezone offsets and safely coerces finite numeric-string limits. |
| apps/sim/tools/logfire/types.ts | Extends token-info response types and documents the pending-span record kind. |
| apps/sim/tools/generated/tool-outputs.ts | Regenerates tool output metadata following the Logfire output changes. |
Reviews (4): Last reviewed commit: "chore(skills): sync validate-integration..." | Re-trigger Greptile
…rand chrome - gate each block output on the operations that actually return it - swap in the official Logfire mark, black tile with brand-magenta bare icon - move host to advanced mode and alphabetize the tool registry entries - add track-logfire-llm-cost and verify-logfire-token-target skills
…fields - accept a numeric-string limit so agent-invoked calls stop silently falling back to Logfire's 100-row default - keep an hour-only UTC offset intact instead of producing +05Z - surface expiresAt and spendingCapReachedAt on Get Token Info - document pending_span as a fourth record kind
081f3fb to
80ed39e
Compare
|
@cursor review |
… skill - regenerate apps/sim/tools/generated/tool-outputs.ts, which CI's tool-metadata:check requires after a tool output change - add the regeneration step and artifact-diff guidance to the validate-integration skill so the gate stops being missed
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 509865f. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 913f067. Configure here.
Summary
pydantic/logfireSDK source. The wire contract was already correct — endpoints,include_schema,deployment_environmentas an array, the2020-01-01min_timestampfallback, the token-region regex, and all 15recordscolumns all check out.rows/rowCount/columns/sqlit never returns, and Run SQL Query surfacedsql/organizationName/projectName.#E620E9) asiconColorfor bare renders.hostto advanced mode (self-hosting is rare;regionwas already advanced) and alphabetized the four tool registry entries.track-logfire-llm-cost(from Logfire's LLM-cost cookbook) andverify-logfire-token-target.Type of Change
Testing
55/55 Logfire tool tests pass. Typecheck reports no errors in any changed file, lint is clean, and I verified at runtime that the block resolves from
BLOCK_REGISTRY, its meta fromBLOCK_META_REGISTRY, all fourtools.accessentries exist in the tool registry, and the operation dropdown maps 1:1 to them. Docs regenerated. Not yet exercised against a live Logfire read token.Checklist