Skip to content

improvement(skills): ask for feature flag granularity - #6238

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
feat/feature-flag-skill-ask
Aug 4, 2026
Merged

improvement(skills): ask for feature flag granularity#6238
TheodoreSpeaks merged 1 commit into
stagingfrom
feat/feature-flag-skill-ask

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • ask whether feature flags need global or scoped rollout before implementation
  • recommend global flags and avoid unnecessary request context
  • sync the Claude and Cursor command projections

Type of Change

  • Improvement

Testing

  • bun run lint
  • Full ship audit suite passed

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 4, 2026 3:34am

Request Review

@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation-only changes to agent skills and command files; no application or feature-flag runtime code is modified.

Overview
Updates the add-feature-flag skill and mirrored Claude/Cursor command docs so agents ask whether a flag should be global or scoped before writing code, default to global isFeatureEnabled('<flag-name>') without threading user/org context, and only wire org/user/admin dimensions when the user explicitly chooses scoped rollout.

The workflow steps are renumbered and expanded (granularity confirmation → define → gate → AppConfig → test → cleanup). AppConfig rule documentation now uses adminEnabled instead of admins, aligned with the runtime FeatureFlagRule shape.

Reviewed by Cursor Bugbot for commit 596aefb. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the feature-flag skill to ask for rollout granularity before implementation and recommend context-free global flags by default.

  • Documents separate global and organization/user/admin-scoped call patterns.
  • Corrects the admin rule name to adminEnabled.
  • Synchronizes the Claude and Cursor command projections with the canonical skill.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The revised instructions match the existing feature-flag evaluator’s context-free global behavior and adminEnabled schema, and all command projections remain synchronized.

Important Files Changed

Filename Overview
.agents/skills/add-feature-flag/SKILL.md Updates the canonical skill with granularity confirmation, global and scoped usage guidance, and runtime-accurate rule names.
.claude/commands/add-feature-flag.md Keeps the generated Claude command projection synchronized with the canonical feature-flag skill.
.cursor/commands/add-feature-flag.md Keeps the body-only Cursor command projection synchronized with the canonical feature-flag skill.

Reviews (1): Last reviewed commit: "improvement(skills): ask for feature fla..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit 40cbee4 into staging Aug 4, 2026
6 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the feat/feature-flag-skill-ask branch August 4, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant