-
Notifications
You must be signed in to change notification settings - Fork 3.8k
v0.7.57: forking webhook URL, markdown editor overflow, fix ui improvements #6287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
020ec68
fix(sidebar): keep the collapsed profile chip inside the rail (#6282)
waleedlatif1 5718def
feat(logs): open the workflow from the log details panel (#6275)
mzxchandra 623003e
fix(providers): name the failing phase of a stalled OpenAI call, and …
waleedlatif1 0fce535
fix(files): stop markdown reflow on open by matching placeholder wrap…
waleedlatif1 6cc25f6
improvement(forking): make webhook url mapping clear (#6272)
icecrasher321 53c3bea
fix(providers): name the header phase on streaming OpenAI requests (#…
waleedlatif1 402f862
fix(forking): make the trigger URL preview reflect the user's actual …
icecrasher321 0583e20
improvement(emcn): let every primitive inherit the document font weig…
waleedlatif1 2d90c72
fix(wand): stop markdown code fences landing in generated code (#6289)
waleedlatif1 9ff7eae
feat(copilot): attribute tool metrics to invoking agents (#6266)
j15z File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| --- | ||
| paths: | ||
| - "apps/sim/**/*.tsx" | ||
| - "apps/sim/components/emcn/**" | ||
| --- | ||
|
|
||
| # UI Copy | ||
|
|
||
| **Do not add subtitles, helper text, or descriptive copy beneath headings, labels, cards, or settings by default.** Prefer one concise, self-explanatory heading or label. Only add supporting copy when the user explicitly asks for it, or when it is necessary to prevent misunderstanding or error — and never use it to restate the heading. | ||
|
|
||
| This applies to product surfaces: settings rows, modals, panels, cards, list rows, empty states, form fields, and section headers. Marketing surfaces (`app/(landing)`, docs) are governed by `constitution.md` instead. | ||
|
|
||
| **Carve-out — settings section metadata.** `SettingsNavigationItem.description` in `components/settings/navigation.ts` stays required, and `SettingsPanel` keeps rendering it as the page subtitle. Settings sections are reached through a nav list where the description is the only thing distinguishing adjacent sections, so it earns its place by the "prevents misunderstanding" test. Keep those descriptions verb-first and one line, per `sim-settings-pages.md`. Everything else on a settings page — inline `<p>` blurbs under section headings, field hints, modal bodies, row subtitles — follows the default rule above. | ||
|
|
||
| ## The default is no description | ||
|
|
||
| ```tsx | ||
| // ✗ Bad — the subtitle restates the heading | ||
| <h3>API Keys</h3> | ||
| <p className='text-[var(--text-muted)] text-caption'>Manage your API keys.</p> | ||
|
|
||
| // ✗ Bad — decorative filler under a field label | ||
| <ChipModalField title='Workspace name' hint='The name of your workspace.' /> | ||
|
|
||
| // ✓ Good — the label carries the whole meaning | ||
| <h3>API Keys</h3> | ||
| <ChipModalField title='Workspace name' /> | ||
| ``` | ||
|
|
||
| If a heading needs a subtitle to be understood, the heading is wrong. Fix the heading — don't append a second line. | ||
|
|
||
| ## When supporting copy earns its place | ||
|
|
||
| Keep (or add) a description only when it carries information the label cannot, and its absence would cause a mistake: | ||
|
|
||
| - **Irreversible or destructive consequences** — "Deleting this workspace removes every workflow and log. This cannot be undone." | ||
| - **A non-obvious format, unit, or bound** — "Comma-separated. Max 50 domains.", "Cost per 1M input tokens." | ||
| - **A security or access implication** — "This key is shown once and grants full workspace access." | ||
| - **A state the user cannot otherwise see** — "Inherited from your organization's policy." | ||
| - **Instructional copy that advances a flow** — "We sent a 6-digit code to you@example.com." | ||
|
|
||
| Everything else — restatements, "Manage your X", "Configure your Y", feature blurbs, encouragement — gets deleted. | ||
|
|
||
| ## Component APIs | ||
|
|
||
| Description/hint slots on shared components are **optional**, never required, and must reserve no layout space when omitted. A component that forces every consumer to supply a subtitle forces every consumer to violate this rule. When adding a new shared component, ship it without a description slot and add one only once a real caller meets the bar above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| --- | ||
| description: UI copy conventions — no default subtitles or helper text under headings, labels, cards, or settings | ||
| globs: ["apps/sim/**/*.tsx"] | ||
| --- | ||
| # UI Copy | ||
|
|
||
| **Do not add subtitles, helper text, or descriptive copy beneath headings, labels, cards, or settings by default.** Prefer one concise, self-explanatory heading or label. Only add supporting copy when the user explicitly asks for it, or when it is necessary to prevent misunderstanding or error — and never use it to restate the heading. | ||
|
|
||
| This applies to product surfaces: settings rows, modals, panels, cards, list rows, empty states, form fields, and section headers. Marketing surfaces (`app/(landing)`, docs) are governed by `constitution.mdc` instead. | ||
|
|
||
| **Carve-out — settings section metadata.** `SettingsNavigationItem.description` in `components/settings/navigation.ts` stays required, and `SettingsPanel` keeps rendering it as the page subtitle. Settings sections are reached through a nav list where the description is the only thing distinguishing adjacent sections. Everything else on a settings page — inline `<p>` blurbs under section headings, field hints, modal bodies, row subtitles — follows the default rule above. | ||
|
|
||
| ## The default is no description | ||
|
|
||
| ```tsx | ||
| // ✗ Bad — the subtitle restates the heading | ||
| <h3>API Keys</h3> | ||
| <p className='text-[var(--text-muted)] text-caption'>Manage your API keys.</p> | ||
|
|
||
| // ✗ Bad — decorative filler under a field label | ||
| <ChipModalField title='Workspace name' hint='The name of your workspace.' /> | ||
|
|
||
| // ✓ Good — the label carries the whole meaning | ||
| <h3>API Keys</h3> | ||
| <ChipModalField title='Workspace name' /> | ||
| ``` | ||
|
|
||
| If a heading needs a subtitle to be understood, the heading is wrong. Fix the heading — don't append a second line. | ||
|
|
||
| ## When supporting copy earns its place | ||
|
|
||
| Keep (or add) a description only when it carries information the label cannot, and its absence would cause a mistake: | ||
|
|
||
| - **Irreversible or destructive consequences** — "Deleting this workspace removes every workflow and log. This cannot be undone." | ||
| - **A non-obvious format, unit, or bound** — "Comma-separated. Max 50 domains.", "Cost per 1M input tokens." | ||
| - **A security or access implication** — "This key is shown once and grants full workspace access." | ||
| - **A state the user cannot otherwise see** — "Inherited from your organization's policy." | ||
| - **Instructional copy that advances a flow** — "We sent a 6-digit code to you@example.com." | ||
|
|
||
| Everything else — restatements, "Manage your X", "Configure your Y", feature blurbs, encouragement — gets deleted. | ||
|
|
||
| ## Component APIs | ||
|
|
||
| Description/hint slots on shared components are **optional**, never required, and must reserve no layout space when omitted. A component that forces every consumer to supply a subtitle forces every consumer to violate this rule. When adding a new shared component, ship it without a description slot and add one only once a real caller meets the bar above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.