fix(images): fix mship image handling - #6357
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThe PR changes Copilot attachment preparation so one failed upload is represented by an omission marker while valid sibling attachments continue to be prepared.
Confidence Score: 4/5The PR appears safe to merge after considering the non-blocking need to normalize filenames in failed-attachment context markers. Per-file failure isolation preserves valid sibling attachments as intended, but the new failure path exposes raw attachment metadata to model-visible context instead of following the successful path's normalization. Files Needing Attention: apps/sim/lib/copilot/chat/payload.ts
|
| Filename | Overview |
|---|---|
| apps/sim/lib/copilot/chat/payload.ts | Adds per-attachment failure isolation, but embeds an unnormalized client filename in the new model-visible failure marker. |
| apps/sim/lib/copilot/chat/payload.test.ts | Updates coverage to verify that failed attachments are omitted while valid siblings remain available. |
| bun.lock | Removes only the top-level configVersion metadata field, with no dependency resolution changes shown. |
Reviews (1): Last reviewed commit: "fix(mship): fix image handling" | Re-trigger Greptile
|
Summary
Brief description of what this PR does and why.
Companion: https://github.com/simstudioai/mothership/pull/412
Type of Change
Testing
How has this been tested? What should reviewers focus on?
Checklist
Screenshots/Videos