fix(agent): overly broad check for secrets protection - #6399
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryHigh Risk Overview Block executor splits provenance registries: log-facing inputs use resolver projections only, successful outputs use a handler-narrowed registry, and failures/stream errors can use Agent handler stops treating Generic tool handler no longer folds Reviewed by Cursor Bugbot for commit f09556c. Configure here. |
Greptile SummaryThe PR narrows resolved-secret protection to fields that actually cross model, persistence, or diagnostic boundaries while preserving ordinary opaque inputs and internal lookup identifiers.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported Mothership identifier disclosure was invalidated because the authenticated internal route resolves the identifier for lookup and excludes it from the external model payload.
|
| Filename | Overview |
|---|---|
| apps/sim/executor/handlers/agent/agent-handler.ts | Refines model-visible projection, private selector settlement, provider diagnostics, tool provenance, and memory persistence boundaries. |
| apps/sim/executor/handlers/mothership/mothership-handler.ts | Preserves private skill IDs for authenticated internal lookup while projecting only model-visible labels and metadata. |
| apps/sim/executor/execution/block-executor.ts | Projects resolver-recorded secrets from displayed inputs and carries dedicated provenance through streaming and error paths. |
| apps/sim/lib/uploads/utils/model-input.ts | Revises upload model-input classification and projection behavior for inline content versus ordinary resource locators. |
| apps/sim/tools/index.ts | Removes centralized opaque-input rejection behavior that was applied too broadly to ordinary tool request values. |
Reviews (2): Last reviewed commit: "address comments" | Re-trigger Greptile
|
bugbot run |
|
bugbot run |
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f09556c. Configure here.
Summary
Remove overly broad check for secrets for agent handler. And opaque input clearing.
Type of Change
Testing
Tested manually
Checklist