-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(tables): keep row context menu labels on one line #6418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+179
−10
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
packages/emcn/src/components/dropdown-menu/dropdown-menu.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| /** | ||
| * @vitest-environment jsdom | ||
| * | ||
| * Menu rows are a fixed height, so a label that wraps overflows its row and paints over its | ||
| * neighbours. Rows are held to one line and their bare text is wrapped in a truncating box so an | ||
| * over-long label ellipsizes instead of being cut mid-word. These tests cover that wrapping: | ||
| * that it happens, that adjacent text stays in ONE box (two boxes would be two flex items, and | ||
| * the row's `gap` would open between the words), and that it steps aside for `asChild`, where | ||
| * Radix's `Slot` requires exactly one element child. | ||
| */ | ||
| import { act, type ReactNode } from 'react' | ||
| import { createRoot, type Root } from 'react-dom/client' | ||
| import { afterEach, describe, expect, it } from 'vitest' | ||
| import { | ||
| DropdownMenu, | ||
| DropdownMenuCheckboxItem, | ||
| DropdownMenuContent, | ||
| DropdownMenuItem, | ||
| DropdownMenuTrigger, | ||
| } from './dropdown-menu' | ||
|
|
||
| let root: Root | null = null | ||
| let container: HTMLDivElement | null = null | ||
|
|
||
| function openMenu(children: ReactNode) { | ||
| ;(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true | ||
| container = document.createElement('div') | ||
| document.body.appendChild(container) | ||
| root = createRoot(container) | ||
| act(() => | ||
| root?.render( | ||
| <DropdownMenu open modal={false}> | ||
| <DropdownMenuTrigger /> | ||
| <DropdownMenuContent>{children}</DropdownMenuContent> | ||
| </DropdownMenu> | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| function row(selector = '[role="menuitem"]'): HTMLElement { | ||
| const node = document.querySelector(selector) | ||
| if (!node) throw new Error(`No ${selector} rendered`) | ||
| return node as HTMLElement | ||
| } | ||
|
|
||
| afterEach(() => { | ||
| if (root) act(() => root?.unmount()) | ||
| container?.remove() | ||
| root = null | ||
| container = null | ||
| }) | ||
|
|
||
| describe('menu row labels', () => { | ||
| it('wraps a bare text label in a truncating box', () => { | ||
| openMenu(<DropdownMenuItem>Run empty or failed cells on 2 rows</DropdownMenuItem>) | ||
|
|
||
| const labels = row().querySelectorAll('span') | ||
| expect(labels).toHaveLength(1) | ||
| expect(labels[0].textContent).toBe('Run empty or failed cells on 2 rows') | ||
| expect(labels[0].className).toContain('truncate') | ||
| }) | ||
|
|
||
| it('keeps the row on one line', () => { | ||
| openMenu(<DropdownMenuItem>Delete 2 rows</DropdownMenuItem>) | ||
|
|
||
| expect(row().className).toContain('whitespace-nowrap') | ||
| }) | ||
|
|
||
| it('coalesces adjacent text into a single box', () => { | ||
| const count = 2 | ||
| openMenu( | ||
| <DropdownMenuItem> | ||
| <svg aria-hidden /> | ||
| Delete {count} rows | ||
| </DropdownMenuItem> | ||
| ) | ||
|
|
||
| const labels = row().querySelectorAll('span') | ||
| expect(labels).toHaveLength(1) | ||
| expect(labels[0].textContent).toBe('Delete 2 rows') | ||
| }) | ||
|
|
||
| it('wraps a checkbox row label, leaving the check indicator its own box', () => { | ||
| openMenu(<DropdownMenuCheckboxItem checked>Show archived workflows</DropdownMenuCheckboxItem>) | ||
|
|
||
| const labels = row('[role="menuitemcheckbox"]').querySelectorAll('span') | ||
| const label = Array.from(labels).find((node) => node.className.includes('truncate')) | ||
| expect(label?.textContent).toBe('Show archived workflows') | ||
| }) | ||
|
|
||
| it('leaves an asChild row alone so Slot still sees one element child', () => { | ||
| openMenu( | ||
| <DropdownMenuItem asChild> | ||
| <a href='/workflows'>Open workflow</a> | ||
| </DropdownMenuItem> | ||
| ) | ||
|
|
||
| const link = row('a') | ||
| expect(link.textContent).toBe('Open workflow') | ||
| expect(link.querySelector('span')).toBeNull() | ||
| }) | ||
|
|
||
| it('leaves a label the consumer already wrapped as a single box', () => { | ||
| openMenu( | ||
| <DropdownMenuItem> | ||
| <span>Add 2 rows to Chat</span> | ||
| </DropdownMenuItem> | ||
| ) | ||
|
|
||
| expect(row().querySelectorAll('span')).toHaveLength(1) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.