fix(mcp): apply the workspace personal API key setting to MCP serve auth - #6429
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview
Tests cover rejection of personal keys, allowance of workspace keys when personal keys are disabled, and updated mocks with Reviewed by Cursor Bugbot for commit e636d8f. Configure here. |
Greptile SummaryThe PR makes MCP serve authorization honor each workspace’s personal API-key setting using data already loaded by the server query.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The joined workspace setting is a non-nullable boolean, the new check targets only authenticated personal API keys, and the tests cover both the rejection and workspace-key exemption paths.
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/mcp/serve/[serverId]/route.ts | Correctly adds workspace-level personal API-key enforcement to the authenticated MCP serve path without changing workspace-key behavior. |
| apps/sim/app/api/mcp/serve/[serverId]/route.test.ts | Adds focused regression coverage for rejecting disallowed personal keys and continuing to accept workspace keys. |
Reviews (1): Last reviewed commit: "fix(mcp): apply the workspace personal A..." | Re-trigger Greptile
Summary
getServeralready performs, so there is no extra queryType of Change
Testing
Unit tests added; full MCP + workflow execute + api-key suites pass
Checklist