Skip to content

fix(knowledge): validate tag slots and share the tag-name length limit #6438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waleedlatif1 wants to merge 1 commit into from
+5 −0
Closed

fix(knowledge): validate tag slots and share the tag-name length limit #6438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/sim/app/api/knowledge/[id]/tag-definitions/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ export const POST = withRouteHandler(
if (!parsed.success) return parsed.response

const validatedData = parsed.data.body
/**
* Defense-in-depth runtime check: the contract types `fieldType` as a plain
* string because tightening to the field-type enum cascades into UI form
* state types. Cast here to allow `includes` to accept the wider input.
*/
if (!(SUPPORTED_FIELD_TYPES as readonly string[]).includes(validatedData.fieldType)) {
return NextResponse.json(
{ error: 'Invalid request data', details: 'Invalid field type' },
Expand Down
Loading