Skip to content

chore(skills): remove the unused skills-lock.json - #6503

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-skills-lock
Aug 10, 2026
Merged

chore(skills): remove the unused skills-lock.json#6503
waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-skills-lock

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Deleted the root skills-lock.json. It was written by a third-party skills-installer CLI and rode into the repo as a side effect of improvement(landing): refine hero and mothership visuals #5181 — nothing reads it (scripts/sync-skills.ts treats .agents/skills/<name>/SKILL.md as canonical, and no script, workflow, or Dockerfile references the file).
  • Its only real content was provenance for the three vendored skills, so that moves to a source: frontmatter line on each SKILL.md (design-taste-frontend, emil-design-eng, make-interfaces-feel-better).

Type of Change

  • Chore (maintenance)

Testing

bun run skills:check passes — 34 skills in sync. The projector copies only description/argument-hint, so .claude/commands and .cursor/commands are byte-identical and the new frontmatter key can't make a projection stale. bun run lint clean.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The lockfile was written by a third-party skills-installer CLI and rode
into the repo as a side effect of #5181. Nothing reads it: sync-skills.ts
treats `.agents/skills/<name>/SKILL.md` as canonical, and no script,
workflow, or Dockerfile references the file.

Its only real content was provenance for the three vendored skills, so
that moves to a `source:` frontmatter line on each SKILL.md. The
projector copies only `description`/`argument-hint`, leaving
`.claude/commands` and `.cursor/commands` byte-identical.
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Building Building Preview Aug 10, 2026 10:13pm

Request Review

@cursor

cursor Bot commented Aug 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation and metadata-only cleanup with no runtime or sync logic changes; skill projection ignores the new frontmatter key.

Overview
Removes root skills-lock.json, which nothing in the repo consumed (canonical skills live under .agents/skills/<name>/SKILL.md).

Provenance for the three vendored design skills moves into each skill’s YAML frontmatter as a source: URL (design-taste-frontend, emil-design-eng, make-interfaces-feel-better), replacing the lock file’s GitHub paths and hashes.

Reviewed by Cursor Bugbot for commit f6b2c99. Configure here.

@waleedlatif1
waleedlatif1 merged commit 328d985 into staging Aug 10, 2026
20 of 21 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/remove-skills-lock branch August 10, 2026 22:14
@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes an unused third-party-generated skills lockfile while preserving provenance in canonical skill metadata.

  • Adds a source field to the three vendored skill definitions.
  • Deletes the unreferenced root skills-lock.json.
  • Leaves generated Claude and Cursor command projections unchanged.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

Repository synchronization and projection logic uses canonical SKILL.md files and ignores the added source metadata, while no script, workflow, build configuration, or documented repository process consumes the deleted lockfile.

Important Files Changed

Filename Overview
.agents/skills/design-taste-frontend/SKILL.md Adds inert provenance metadata without changing the fields consumed by skill projection.
.agents/skills/emil-design-eng/SKILL.md Adds inert provenance metadata without changing the fields consumed by skill projection.
.agents/skills/make-interfaces-feel-better/SKILL.md Adds inert provenance metadata without changing the fields consumed by skill projection.
skills-lock.json Removes an unused installer-generated lockfile with no repository consumers.

Reviews (1): Last reviewed commit: "chore(skills): remove the unused skills-..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant